Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 12316118: Enabled Mosaic view on each volume. (Closed)

Created:
7 years, 10 months ago by mtomasz
Modified:
7 years, 9 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, tfarina, rginda+watch_chromium.org, arv+watch_chromium.org, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Enabled Mosaic view on each volume. Since the Image loader extension has been introduced, there is no image size bottle-neck anymore. Therefore, we can generate thumbnails for full-resolution images without affecting the ui. However, generating thumbnails from a full-resolution image takes time, therefore the mosaic mode's been modified, so it is possible to use the mosaic view while loading pictures. There is no need to wait until all the images are loaded. TEST=Check mosaic view on usb drive in downloads and on google drive. BUG=176216 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185227

Patch Set 1 #

Patch Set 2 : Cleaned up. #

Total comments: 10

Patch Set 3 : Addressed comments. #

Total comments: 4

Patch Set 4 : Addressed comments. #

Patch Set 5 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -75 lines) Patch
M chrome/browser/resources/file_manager/css/gallery.css View 1 chunk +14 lines, -3 lines 0 comments Download
M chrome/browser/resources/file_manager/css/photo_import.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/file_manager/js/file_tasks.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/file_manager/js/media/media_util.js View 1 2 3 4 13 chunks +39 lines, -10 lines 0 comments Download
M chrome/browser/resources/file_manager/js/photo/gallery.js View 1 2 3 5 chunks +20 lines, -11 lines 0 comments Download
M chrome/browser/resources/file_manager/js/photo/mosaic_mode.js View 1 2 3 14 chunks +141 lines, -49 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
mtomasz
@yoshiki: PTAL.
7 years, 10 months ago (2013-02-26 07:57:45 UTC) #1
yoshiki
https://codereview.chromium.org/12316118/diff/2001/chrome/browser/resources/file_manager/js/media/media_util.js File chrome/browser/resources/file_manager/js/media/media_util.js (right): https://codereview.chromium.org/12316118/diff/2001/chrome/browser/resources/file_manager/js/media/media_util.js#newcode96 chrome/browser/resources/file_manager/js/media/media_util.js:96: * @enum @enum {number} The @enum tag must be ...
7 years, 10 months ago (2013-02-26 08:21:44 UTC) #2
mtomasz
Thanks for the fast review. https://codereview.chromium.org/12316118/diff/2001/chrome/browser/resources/file_manager/js/media/media_util.js File chrome/browser/resources/file_manager/js/media/media_util.js (right): https://codereview.chromium.org/12316118/diff/2001/chrome/browser/resources/file_manager/js/media/media_util.js#newcode96 chrome/browser/resources/file_manager/js/media/media_util.js:96: * @enum On 2013/02/26 ...
7 years, 10 months ago (2013-02-26 08:39:19 UTC) #3
yoshiki
https://codereview.chromium.org/12316118/diff/2001/chrome/browser/resources/file_manager/js/media/media_util.js File chrome/browser/resources/file_manager/js/media/media_util.js (right): https://codereview.chromium.org/12316118/diff/2001/chrome/browser/resources/file_manager/js/media/media_util.js#newcode96 chrome/browser/resources/file_manager/js/media/media_util.js:96: * @enum On 2013/02/26 08:39:20, mtomasz wrote: > On ...
7 years, 10 months ago (2013-02-26 08:50:27 UTC) #4
mtomasz
https://codereview.chromium.org/12316118/diff/2001/chrome/browser/resources/file_manager/js/media/media_util.js File chrome/browser/resources/file_manager/js/media/media_util.js (right): https://codereview.chromium.org/12316118/diff/2001/chrome/browser/resources/file_manager/js/media/media_util.js#newcode96 chrome/browser/resources/file_manager/js/media/media_util.js:96: * @enum On 2013/02/26 08:50:27, yoshiki wrote: > On ...
7 years, 10 months ago (2013-02-27 00:55:31 UTC) #5
yoshiki
lgtm
7 years, 9 months ago (2013-02-28 02:33:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/12316118/11001
7 years, 9 months ago (2013-02-28 03:59:06 UTC) #7
commit-bot: I haz the power
Failed to apply patch for chrome/browser/resources/file_manager/js/media/media_util.js: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 9 months ago (2013-02-28 03:59:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/12316118/14002
7 years, 9 months ago (2013-02-28 08:05:27 UTC) #9
commit-bot: I haz the power
7 years, 9 months ago (2013-02-28 11:34:48 UTC) #10
Message was sent while issue was closed.
Change committed as 185227

Powered by Google App Engine
This is Rietveld 408576698