Add functionality to get full stack trace when exceptions are thrown.

runtime/vm/exceptions.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/exceptions.h"
 
 #include "vm/dart_api_impl.h"
 #include "vm/dart_entry.h"
 #include "vm/debugger.h"
 #include "vm/flags.h"
@@ skipping 185 matching lines @@
   // stack as Exceptions::Throw should happen only after a dart
   // invocation has been done.
   ASSERT(handler_pc != 0);
 
   // TODO(5411263): At some point we can optimize by figuring out if a
   // stack trace is needed based on whether the catch code specifies a
   // stack trace object or there is a rethrow in the catch clause.
   Stacktrace& stacktrace = Stacktrace::Handle();
   if (pc_offset_list.Length() != 0) {
     if (existing_stacktrace.IsNull()) {
-      stacktrace = Stacktrace::New(func_list, code_list, pc_offset_list);
+      const Array& func_array = Array::Handle(Array::MakeArray(func_list));
+      const Array& code_array = Array::Handle(Array::MakeArray(code_list));
+      const Array& pc_offset_array =
+          Array::Handle(Array::MakeArray(pc_offset_list));
+
+      stacktrace = Stacktrace::New(func_array, code_array, pc_offset_array);
     } else {
       stacktrace ^= existing_stacktrace.raw();
       stacktrace.Append(func_list, code_list, pc_offset_list);
+      // Since we are re throwing and appending to the existing stack trace
+      // we clear out the catch trace collected in the existing stack trace
+      // as that trace will not be valid anymore.
+      stacktrace.SetCatchStacktrace(Object::empty_array(),
+                                    Object::empty_array(),
+                                    Object::empty_array());
     }
   } else {
     stacktrace ^= existing_stacktrace.raw();
+    // Since we are re throwing the existing stack trace
+    // we clear out the catch trace collected in it
+    // as that trace will not be valid anymore.
+    stacktrace.SetCatchStacktrace(Object::empty_array(),
+                                  Object::empty_array(),
+                                  Object::empty_array());
   }
   if (FLAG_print_stacktrace_at_throw) {
     OS::Print("Exception '%s' thrown:\n", exception.ToCString());
     OS::Print("%s\n", stacktrace.ToCString());
   }
   if (handler_exists) {
     // Found a dart handler for the exception, jump to it.
     JumpToExceptionHandler(handler_pc,
                            handler_sp,
                            handler_fp,
@@ skipping 257 matching lines @@
       break;
   }
 
   return DartLibraryCalls::ExceptionCreate(library,
                                            *class_name,
                                            *constructor_name,
                                            arguments);
 }
 
 }  // namespace dart