Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5080)

Unified Diff: chrome/browser/ui/webui/options/content_settings_handler.cc

Issue 12316077: Move the parsing of app.launch related keys out of Extension class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/content_settings_handler.cc
diff --git a/chrome/browser/ui/webui/options/content_settings_handler.cc b/chrome/browser/ui/webui/options/content_settings_handler.cc
index 04cee719745d92b50d807b7ceaea09b59b934a49..10c9a5255914f1d0149ee032d11cc9cd94d714c7 100644
--- a/chrome/browser/ui/webui/options/content_settings_handler.cc
+++ b/chrome/browser/ui/webui/options/content_settings_handler.cc
@@ -28,6 +28,7 @@
#include "chrome/common/chrome_switches.h"
#include "chrome/common/content_settings.h"
#include "chrome/common/content_settings_pattern.h"
+#include "chrome/common/extensions/app_launch_manifest_handler.h"
#include "chrome/common/extensions/extension_set.h"
#include "chrome/common/extensions/permissions/api_permission.h"
#include "chrome/common/pref_names.h"
@@ -228,7 +229,8 @@ void AddExceptionsGrantedByHostedApps(
AddExceptionForHostedApp(url_pattern, **extension, exceptions);
}
// Retrieve the launch URL.
- std::string launch_url_string = (*extension)->launch_web_url();
+ std::string launch_url_string =
+ extensions::AppLaunchInfo::GetLaunchWebUrl(*extension);
GURL launch_url(launch_url_string);
// Skip adding the launch URL if it is part of the web extent.
if (web_extent.MatchesURL(launch_url)) continue;

Powered by Google App Engine
This is Rietveld 408576698