Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_web_unittest.cc

Issue 12316077: Move the parsing of app.launch related keys out of Extension class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/strings/string_number_conversions.h"
6 #include "chrome/common/extensions/app_launcher_info.h"
7 #include "chrome/common/extensions/extension.h"
8 #include "chrome/common/extensions/extension_manifest_constants.h"
5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 9 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
6
7 #include "base/strings/string_number_conversions.h"
8 #include "base/utf_string_conversions.h"
9 #include "chrome/common/extensions/extension_manifest_constants.h"
10 #include "extensions/common/error_utils.h" 10 #include "extensions/common/error_utils.h"
11 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
12 12
13 using extensions::ErrorUtils; 13 using extensions::ErrorUtils;
14 using extensions::Extension; 14 using extensions::Extension;
15 15
16 namespace errors = extension_manifest_errors; 16 namespace errors = extension_manifest_errors;
17 17
18 TEST_F(ExtensionManifestTest, AppWebUrls) { 18 class WebManifestTest : public ExtensionManifestTest {
19 protected:
20 virtual void SetUp() OVERRIDE {
21 ExtensionManifestTest::SetUp();
22 (new extensions::AppLaunchManifestHandler)->Register();
23 }
24 };
25
26 TEST_F(WebManifestTest, AppWebUrls) {
19 Testcase testcases[] = { 27 Testcase testcases[] = {
20 Testcase("web_urls_wrong_type.json", errors::kInvalidWebURLs), 28 Testcase("web_urls_wrong_type.json", errors::kInvalidWebURLs),
21 Testcase("web_urls_invalid_1.json", 29 Testcase("web_urls_invalid_1.json",
22 ErrorUtils::FormatErrorMessage( 30 ErrorUtils::FormatErrorMessage(
23 errors::kInvalidWebURL, 31 errors::kInvalidWebURL,
24 base::IntToString(0), 32 base::IntToString(0),
25 errors::kExpectString)), 33 errors::kExpectString)),
26 Testcase("web_urls_invalid_2.json", 34 Testcase("web_urls_invalid_2.json",
27 ErrorUtils::FormatErrorMessage( 35 ErrorUtils::FormatErrorMessage(
28 errors::kInvalidWebURL, 36 errors::kInvalidWebURL,
(...skipping 20 matching lines...) Expand all
49 EXPECT_TYPE_ERROR); 57 EXPECT_TYPE_ERROR);
50 58
51 LoadAndExpectSuccess("web_urls_has_port.json"); 59 LoadAndExpectSuccess("web_urls_has_port.json");
52 60
53 scoped_refptr<Extension> extension( 61 scoped_refptr<Extension> extension(
54 LoadAndExpectSuccess("web_urls_default.json")); 62 LoadAndExpectSuccess("web_urls_default.json"));
55 ASSERT_EQ(1u, extension->web_extent().patterns().size()); 63 ASSERT_EQ(1u, extension->web_extent().patterns().size());
56 EXPECT_EQ("*://www.google.com/*", 64 EXPECT_EQ("*://www.google.com/*",
57 extension->web_extent().patterns().begin()->GetAsString()); 65 extension->web_extent().patterns().begin()->GetAsString());
58 } 66 }
OLDNEW
« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698