Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1468)

Issue 12316073: Add DEPS for new third party library in third_party/openmax_dl. (Closed)

Created:
7 years, 10 months ago by Raymond Toy (Google)
Modified:
7 years, 9 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add DEPS for new third party library in third_party/openmax_dl. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190022

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M DEPS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Raymond Toy (Google)
+ ajm I think r3504 is the correct svn version; it's the latest.
7 years, 10 months ago (2013-02-22 18:43:39 UTC) #1
ajm
lgtm https://codereview.chromium.org/12316073/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/12316073/diff/1/DEPS#newcode43 DEPS:43: "openmax_dl_revision": "3504", This is only used once, so ...
7 years, 10 months ago (2013-02-22 19:04:38 UTC) #2
ajm
On 2013/02/22 18:43:39, rtoy wrote: > + ajm > > I think r3504 is the ...
7 years, 10 months ago (2013-02-22 19:04:48 UTC) #3
Raymond Toy (Google)
On 2013/02/22 19:04:38, ajm wrote: > lgtm > > https://codereview.chromium.org/12316073/diff/1/DEPS > File DEPS (right): > ...
7 years, 9 months ago (2013-02-25 17:58:06 UTC) #4
szager
lgtm
7 years, 9 months ago (2013-02-26 18:32:30 UTC) #5
Raymond Toy (Google)
On 2013/02/26 18:32:30, szager wrote: > lgtm Thanks, everyone, for reviewing.
7 years, 9 months ago (2013-02-26 18:37:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@google.com/12316073/4001
7 years, 9 months ago (2013-02-26 18:38:47 UTC) #7
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=39322
7 years, 9 months ago (2013-02-26 19:46:45 UTC) #8
Jorge Lucangeli Obes
On 2013/02/26 19:46:45, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 9 months ago (2013-02-27 17:47:41 UTC) #9
Raymond Toy (Google)
Updated openmax_dl revision. Security review completed for that revision.
7 years, 9 months ago (2013-03-22 17:00:29 UTC) #10
Jorge Lucangeli Obes
On 2013/03/22 17:00:29, rtoy wrote: > Updated openmax_dl revision. Security review completed for that revision. ...
7 years, 9 months ago (2013-03-22 17:09:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@google.com/12316073/14001
7 years, 9 months ago (2013-03-22 18:11:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@google.com/12316073/14001
7 years, 9 months ago (2013-03-23 14:42:34 UTC) #13
commit-bot: I haz the power
7 years, 9 months ago (2013-03-23 16:27:21 UTC) #14
Message was sent while issue was closed.
Change committed as 190022

Powered by Google App Engine
This is Rietveld 408576698