Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 12316049: add a use_alsa gyp setting (Closed)

Created:
7 years, 10 months ago by Mostyn Bramley-Moore
Modified:
7 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, tommi (sloooow) - chröme, Daniel Bratell, rogerj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

add a use_alsa gyp setting By adding a gyp setting, we can explicitly disable alsa on various unix targets that don't include alsa. BUG= TEST=Build with use_alsa=0 then run ldd on output binaries to verify libasound is not listed (and is listed if built with use_alsa=1 or unspecified). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185011

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M media/media.gyp View 3 chunks +15 lines, -8 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
DaleCurtis
lgtm https://codereview.chromium.org/12316049/diff/1/media/media.gyp File media/media.gyp (right): https://codereview.chromium.org/12316049/diff/1/media/media.gyp#newcode559 media/media.gyp:559: ['use_alsa==1', { Long term, ideally, I'd like to ...
7 years, 10 months ago (2013-02-21 20:57:29 UTC) #1
Mostyn Bramley-Moore
We are integrating with a number of different embedded linux platforms that provide their own ...
7 years, 10 months ago (2013-02-21 21:34:43 UTC) #2
no longer working on chromium
On 2013/02/21 21:34:43, Mostyn Bramley-Moore wrote: > We are integrating with a number of different ...
7 years, 10 months ago (2013-02-22 13:20:54 UTC) #3
DaleCurtis
Once you have approval you can just click the 'CQ' button and the patch will ...
7 years, 10 months ago (2013-02-22 21:15:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/12316049/1
7 years, 9 months ago (2013-02-27 16:44:23 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-02-27 19:58:15 UTC) #6
Message was sent while issue was closed.
Change committed as 185011

Powered by Google App Engine
This is Rietveld 408576698