Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 12315139: Sort out build dependencies for LinuxUI. (Closed)

Created:
7 years, 9 months ago by Elliot Glaysher
Modified:
7 years, 9 months ago
CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Sort out build dependencies for LinuxUI. LinuxUI now needs to vend NativeTheme instances into code in views/. This means it can't live in ui/base/ because ui/native_theme depends on ui/base/. LinuxUI used to live entirely in ui/base/. When ShellDialog was split off of ui/base/, an intermediary derived interfact was created in ui/shell_dialogs, requiring casting. This a bit ugly and has been cleaned up. It makes more sense to have LinuxUI depend on NativeTheme and ShellDialog, and in turn, be depended on by classes in ui/views/ and chrome/. This patch only moves files and adds interfaces; the actual NativeThemeGtk2 instance will land in a separate patch. BUG=130810 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185705

Patch Set 1 #

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -150 lines) Patch
M chrome/browser/themes/theme_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.h View 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/libgtk2ui.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
D ui/base/linux_ui.h View 1 chunk +0 lines, -50 lines 0 comments Download
D ui/base/linux_ui.cc View 1 chunk +0 lines, -24 lines 0 comments Download
A + ui/linux_ui/linux_ui.h View 1 4 chunks +14 lines, -6 lines 0 comments Download
A + ui/linux_ui/linux_ui.cc View 2 chunks +5 lines, -1 line 0 comments Download
A + ui/linux_ui/linux_ui.gyp View 1 2 chunks +6 lines, -18 lines 0 comments Download
A ui/linux_ui/linux_ui_export.h View 1 chunk +36 lines, -0 lines 0 comments Download
M ui/shell_dialogs.gypi View 1 chunk +2 lines, -1 line 0 comments Download
A ui/shell_dialogs/linux_shell_dialog.h View 1 chunk +40 lines, -0 lines 0 comments Download
A ui/shell_dialogs/linux_shell_dialog.cc View 1 chunk +23 lines, -0 lines 0 comments Download
D ui/shell_dialogs/linux_ui_shell_dialog.h View 1 chunk +0 lines, -29 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/shell_dialogs/select_file_dialog.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M ui/ui.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/views/views.gyp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_linux.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Elliot Glaysher
7 years, 9 months ago (2013-02-27 20:44:46 UTC) #1
Ben Goodger (Google)
I'd stick a note into the new component that it should be folded into views ...
7 years, 9 months ago (2013-03-01 17:36:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/12315139/14001
7 years, 9 months ago (2013-03-01 20:35:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/12315139/14001
7 years, 9 months ago (2013-03-02 16:08:04 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2013-03-02 16:45:21 UTC) #5
Message was sent while issue was closed.
Change committed as 185705

Powered by Google App Engine
This is Rietveld 408576698