Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 12315131: Make SkTDArray accessors const-friendly (Closed)

Created:
7 years, 9 months ago by jvanverth1
Modified:
7 years, 9 months ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Make SkTDArray accessors const-friendly. This change creates const and non-const versions of SkTDArray::begin(), end(), operator[]() and getAt(). This will keep us from inadvertently changing a const SkTDArray, which the previous signatures allowed. Committed: http://code.google.com/p/skia/source/detail?r=7902

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -19 lines) Patch
M include/core/SkTDArray.h View 2 chunks +15 lines, -5 lines 0 comments Download
M include/core/SkTDict.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkPathHeap.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkPictureFlat.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTHashCache.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/images/SkImageDecoder_libbmp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFFont.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFFont.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFTypes.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pdf/SkPDFTypes.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
jvanverth1
(it's not clear to me that we need getAt(), but I wasn't sure of the ...
7 years, 9 months ago (2013-02-27 16:08:21 UTC) #1
jvanverth1
On 2013/02/27 16:08:21, JimVV wrote: > (it's not clear to me that we need getAt(), ...
7 years, 9 months ago (2013-02-27 16:14:06 UTC) #2
bsalomon
On 2013/02/27 16:14:06, JimVV wrote: > On 2013/02/27 16:08:21, JimVV wrote: > > (it's not ...
7 years, 9 months ago (2013-02-27 18:45:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/12315131/1
7 years, 9 months ago (2013-02-27 19:52:42 UTC) #4
commit-bot: I haz the power
Presubmit check for 12315131-1 failed and returned exit status 1. INFO:root:Found 11 file(s). Running presubmit ...
7 years, 9 months ago (2013-02-27 19:52:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/12315131/1
7 years, 9 months ago (2013-02-28 19:03:00 UTC) #6
commit-bot: I haz the power
7 years, 9 months ago (2013-02-28 19:03:17 UTC) #7
Message was sent while issue was closed.
Change committed as 7902

Powered by Google App Engine
This is Rietveld 408576698