Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: test/mjsunit/string-replace.js

Issue 12315130: Fix wrong test in r13766 (Insert conversion to string in string.replace). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/string-replace.js
diff --git a/test/mjsunit/string-replace.js b/test/mjsunit/string-replace.js
index d9a274d57fb0035d6eeaca636ae554e8110c12d1..de921155759cc5fd3477113727a8a44c393f1ab7 100644
--- a/test/mjsunit/string-replace.js
+++ b/test/mjsunit/string-replace.js
@@ -225,7 +225,7 @@ var side_effect_flag = false;
var replace_obj_side_effects = {
toString: function() { side_effect_flag = true; return "x" }
}
-assertEquals("abc", "abc".replace(/z/g, function() { return "x"; }));
+assertEquals("abc", "abc".replace(/z/g, replace_obj_side_effects));
assertTrue(side_effect_flag); // Side effect triggers even without a match.
var regexp99pattern = "";
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698