Make sure .RC file including elevated_controller.tlb is rebuilt every time .TLB is updated.

remoting/remoting.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     # TODO(dmaclach): can we pick this up some other way? Right now it's
     # duplicated from chrome.gyp
     'chromium_code': 1,
 
@@ skipping 1143 matching lines @@
               ],
               'action': [
                 'python',
                 '<(version_py_path)',
                 '-e', 'DAEMON_CONTROLLER_CLSID="<(daemon_controller_clsid)"',
                 '<(RULE_INPUT_PATH)',
                 '<@(_outputs)',
               ],
               'process_outputs_as_sources': 1,
               'message': 'Generating <@(_outputs)',
-              'msvs_cygwin_shell': 1,
+              'msvs_cygwin_shell': 0,

[Wez, 2013/02/27 07:01:40]

nit: I don't think this is related to the CL as such, so just mention that
you've cleaned up an unnecessary use of Cygwin in the CL description.

[alexeypa (please no reviews), 2013/02/27 16:48:15]

Done.

             },
           ],
         },  # end of target 'remoting_controller_idl'
+
+        # Regenerates 'elevated_controller.rc' every time
+        # 'elevated_controller_idl.templ' changes. 'elevated_controller.tlb'
+        # is embedded into remoting_core.dll's resources. This target makes
+        # sure that when .tlb is updated the resources and the binary are
+        # rebuilt as well. GYP alone is not smart enough to figure out this

[Wez, 2013/02/27 07:01:40]

The rule expresses a dependency on the .templ, but you're saying it triggers a
rebuild every time that the .tlb file changes - how does it achieve that?  Are
they always modified at the same time, for example?  If so, is there a risk that
some future toolchain updates the .templ before the .tlb, so that we miss the
.tlb change?

[alexeypa (please no reviews), 2013/02/27 16:48:15]

The remoting_controller_idl builds .tlb out of .templ.
I updated the description to clarify what is going on there.

+        # dependency on it own.
+        {
+          'target_name': 'remoting_controller_rc',
+          'type': 'none',
+          'sources': [
+            'host/win/elevated_controller_idl.templ',
+          ],
+          'hard_dependency': 1,
+          'direct_dependent_settings': {
+            'include_dirs': [
+              '<(SHARED_INTERMEDIATE_DIR)',
+            ],
+          },
+          'rules': [
+            {
+              'rule_name': 'generate_rc',
+              'extension': 'templ',
+              'outputs': [
+                '<(SHARED_INTERMEDIATE_DIR)/remoting/host/elevated_controller.rc',
+              ],
+              'action': [
+                'echo 1 typelib "remoting/host/elevated_controller.tlb" > <@(_outputs)',

[Wez, 2013/02/27 07:01:40]

This writes the same single line to the file every time it generates it, so
you're effectively just "touch"ing it, each time the .templ changes?

[alexeypa (please no reviews), 2013/02/27 16:48:15]

Yes. The contents of the file is important though. Touching somehow implies that
only the file name and last modification time matters, not the contents.

[Wez, 2013/02/27 21:50:00]

It's important to the build step, yes, but that's no different from an #include
- if #include deps were broken you'd just touch the .cc files that included
stuff to make them re-compile, not re-write them in their entirety.

[alexeypa (please no reviews), 2013/02/27 22:06:59]

Touching a source file is a bad idea because the source files are supposed to be
read-only. The file in question is generated, so it is OK to touch it. The
problem is that the file is not guaranteed to exists so we have to generate it
anyway. :-)

+              ],
+              'message': 'Generating <@(_outputs)',
+              'msvs_cygwin_shell': 0,
+            },
+          ],
+        },  # end of target 'remoting_controller_rc'
         {
           'target_name': 'remoting_configurer',
           'type': 'executable',
           'defines': [
             '_ATL_NO_EXCEPTIONS',
           ],
           'dependencies': [
             '../base/base.gyp:base',
             '../crypto/crypto.gyp:crypto',
             'remoting_host',
@@ skipping 99 matching lines @@
           'dependencies': [
             '../base/base.gyp:base',
             '../base/base.gyp:base_static',
             '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
             '../ipc/ipc.gyp:ipc',
             '../media/media.gyp:media',
             '../net/net.gyp:net',
             'remoting_base',
             'remoting_breakpad',
             'remoting_controller_idl',
+            'remoting_controller_rc',
             'remoting_host',
             'remoting_host_event_logger',
             'remoting_host_logging',
             'remoting_me2me_host_static',
             'remoting_protocol',
             'remoting_version_resources',
           ],
           'sources': [
+            '<(SHARED_INTERMEDIATE_DIR)/remoting/host/elevated_controller.rc',
             '<(SHARED_INTERMEDIATE_DIR)/remoting/host/remoting_host_messages.rc',
             '<(SHARED_INTERMEDIATE_DIR)/remoting/remoting_core_version.rc',
             'base/scoped_sc_handle_win.h',
             'host/chromoting_messages.cc',
             'host/chromoting_messages.h',
             'host/config_file_watcher.cc',
             'host/config_file_watcher.h',
             'host/daemon_process.cc',
             'host/daemon_process.h',
             'host/daemon_process_win.cc',
@@ skipping 1263 matching lines @@
                   '../base/allocator/allocator.gyp:allocator',
                 ],
               },
             ],
           ],
         }],  # end of 'toolkit_uses_gtk == 1'
       ],  # end of 'conditions'
     },  # end of target 'remoting_unittests'
   ],  # end of targets
 }