Issue 12315077: Zap holes in dependent code array after deoptimizing a code group.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12315077: Zap holes in dependent code array after deoptimizing a code group. (Closed)

Created:
7 years, 10 months ago by ulan

Modified:
7 years, 10 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Zap holes in dependent code array after deoptimizing a code group. BUG=crash on GC stress builder R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=13715

Patch Set 1 #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	src/objects.cc	View		1 chunk	+6 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with a micro-nit. https://codereview.chromium.org/12315077/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/12315077/diff/1/src/objects.cc#newcode9608 src/objects.cc:9608: // Now the holes are ...

7 years, 10 months ago (2013-02-25 12:18:22 UTC) #2

ulan

Thank you, landing with the comment: // Now the holes are at the end of ...

7 years, 10 months ago (2013-02-25 12:25:54 UTC) #3

ulan

7 years, 10 months ago (2013-02-25 12:27:33 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r13715 (presubmit successful).

Expand Messages | Collapse Messages