Disable Chrome Frame in Win64 build

Disable Chrome Frame in Win64 build

Several parts don't compile, so disabling for now. 
Also suppressing a warning that blocked ninja on x64.

BUG=176875
TBR=brettw@chromium.org


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184368

[jschuh, 2013-02-23 00:06:28]

Fair warning. I told you this was pretty messy.

[jschuh, 2013-02-23 17:06:09]

Robbie, this CL fixes the "All" target and will get Win64 working on the CQ
again. Do you want me to just land it for now, and we can revert or clean it up
in a follow up?

[iannucci, 2013-02-24 04:05:24]

On 2013/02/23 17:06:09, Justin Schuh wrote:
> Robbie, this CL fixes the "All" target and will get Win64 working on the CQ
> again. Do you want me to just land it for now, and we can revert or clean it
up
> in a follow up?

It's OK with me, but I'm not sure it's my call. I think the CQ can wait through
the weekend, I haven't gotten any nastygrams and x64 seems pretty green. :)

[robertshield, 2013-02-25 00:37:35]

LGTM, two nits and one request.

https://codereview.chromium.org/12315062/diff/6/build/all.gyp
File build/all.gyp (right):

https://codereview.chromium.org/12315062/diff/6/build/all.gyp#newcode260
build/all.gyp:260: ]
minor nit, but consider leaving these where they are above and then also
including them in the 'dependencies!' block below. Makes for one less condition
block.

https://codereview.chromium.org/12315062/diff/6/build/all.gyp#newcode574
build/all.gyp:574: ['target_arch!="x64"', {
Same comment here about adding these to the 'dependencies!' block below instead.

https://codereview.chromium.org/12315062/diff/6/chrome/chrome_installer.gypi
File chrome/chrome_installer.gypi (right):

https://codereview.chromium.org/12315062/diff/6/chrome/chrome_installer.gypi#...
chrome/chrome_installer.gypi:295: 'msvs_disabled_warnings': [ 4267, ],
Please update the CL description to include this, if it should be part of this
cl.

[jschuh, 2013-02-25 01:10:02]

Description updated. Leaving if blocks as is since I found the other way a bit
more confusing.

@brettw - TBRing you as an owner of the build files in src/chrome.

https://codereview.chromium.org/12315062/diff/6/build/all.gyp
File build/all.gyp (right):

https://codereview.chromium.org/12315062/diff/6/build/all.gyp#newcode260
build/all.gyp:260: ]
On 2013/02/25 00:37:36, robertshield wrote:
> minor nit, but consider leaving these where they are above and then also
> including them in the 'dependencies!' block below. Makes for one less
condition
> block.

I wrote it that way originally, but it felt more confusing to me. I also bounced
it off @scottmg and @cpu, and they agreed (accepting the additional branch).

https://codereview.chromium.org/12315062/diff/6/chrome/chrome_installer.gypi
File chrome/chrome_installer.gypi (right):

https://codereview.chromium.org/12315062/diff/6/chrome/chrome_installer.gypi#...
chrome/chrome_installer.gypi:295: 'msvs_disabled_warnings': [ 4267, ],
On 2013/02/25 00:37:36, robertshield wrote:
> Please update the CL description to include this, if it should be part of this
> cl.

Oh. This must have been sitting as a local change that I never checked in. I
just verified that it's needed for ninja, so I'll update the description.

[commit-bot: I haz the power, 2013-02-25 01:10:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jschuh@chromium.org/12315062/6

[commit-bot: I haz the power, 2013-02-25 03:28:45]

Change committed as 184368