Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12315004: Migrated sync_file_type and file_change from namespace fileapi to sync_file_system. (Closed)

Created:
7 years, 10 months ago by calvinlo
Modified:
7 years, 10 months ago
Reviewers:
kinuko, nhiroki, tzik
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, darin-cc_chromium.org
Visibility:
Public.

Description

Migrated sync_file_type and file_change from namespace fileapi to sync_file_system. BUG=174870 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184102

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updates after looking at diffs manually #

Patch Set 3 : Couple more fixups. #

Patch Set 4 : f #

Total comments: 6

Patch Set 5 : Hiroki and Kinuko review #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -186 lines) Patch
M chrome/browser/sync_file_system/drive_file_sync_service.h View 1 2 3 4 5 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_service.cc View 1 2 3 4 5 14 chunks +18 lines, -22 lines 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_service_unittest.cc View 1 2 3 4 5 8 chunks +13 lines, -17 lines 0 comments Download
M chrome/browser/sync_file_system/local_change_processor.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/local_file_sync_service.h View 1 2 3 4 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/local_file_sync_service.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/local_file_sync_service_unittest.cc View 1 2 9 chunks +14 lines, -16 lines 0 comments Download
M chrome/browser/sync_file_system/mock_local_change_processor.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/mock_local_change_processor.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/mock_remote_change_processor.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/remote_change_processor.h View 1 2 3 4 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service_unittest.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/fileapi/syncable/file_change.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/fileapi/syncable/file_change.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/fileapi/syncable/file_change_unittest.cc View 1 3 chunks +5 lines, -8 lines 0 comments Download
M webkit/fileapi/syncable/local_file_change_tracker.h View 3 chunks +5 lines, -3 lines 0 comments Download
M webkit/fileapi/syncable/local_file_change_tracker.cc View 4 chunks +15 lines, -11 lines 0 comments Download
M webkit/fileapi/syncable/local_file_change_tracker_unittest.cc View 5 chunks +33 lines, -31 lines 0 comments Download
M webkit/fileapi/syncable/local_file_sync_context.h View 3 chunks +6 lines, -3 lines 0 comments Download
M webkit/fileapi/syncable/local_file_sync_context.cc View 1 6 chunks +16 lines, -12 lines 0 comments Download
M webkit/fileapi/syncable/local_file_sync_context_unittest.cc View 1 2 3 4 5 8 chunks +25 lines, -19 lines 0 comments Download
M webkit/fileapi/syncable/sync_file_metadata.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/fileapi/syncable/sync_file_metadata.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M webkit/fileapi/syncable/sync_file_type.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/fileapi/syncable/syncable_file_system_unittest.cc View 3 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
calvinlo
PTAL. namespace cleanup only.
7 years, 10 months ago (2013-02-20 08:36:26 UTC) #1
kinuko
drive-by https://codereview.chromium.org/12315004/diff/1/chrome/browser/sync_file_system/drive_file_sync_service.h File chrome/browser/sync_file_system/drive_file_sync_service.h (right): https://codereview.chromium.org/12315004/diff/1/chrome/browser/sync_file_system/drive_file_sync_service.h#newcode88 chrome/browser/sync_file_system/drive_file_sync_service.h:88: const sync_file_system::FileChange& change, We shouldn't need this prefix ...
7 years, 10 months ago (2013-02-21 03:58:13 UTC) #2
calvinlo
Sorry, I'm going to look through the diffs manually to fix up some stuff like ...
7 years, 10 months ago (2013-02-21 04:57:49 UTC) #3
calvinlo
Ok I think this is ready now. Please note that before this goes in I'll ...
7 years, 10 months ago (2013-02-21 06:23:46 UTC) #4
kinuko
lgtm https://codereview.chromium.org/12315004/diff/2002/chrome/browser/sync_file_system/local_change_processor.h File chrome/browser/sync_file_system/local_change_processor.h (right): https://codereview.chromium.org/12315004/diff/2002/chrome/browser/sync_file_system/local_change_processor.h#newcode16 chrome/browser/sync_file_system/local_change_processor.h:16: class FileChange; nit: please put extra empty line ...
7 years, 10 months ago (2013-02-21 06:49:57 UTC) #5
nhiroki
LGTM, sorry for the delay in my response. https://codereview.chromium.org/12315004/diff/2002/chrome/browser/sync_file_system/remote_change_processor.h File chrome/browser/sync_file_system/remote_change_processor.h (right): https://codereview.chromium.org/12315004/diff/2002/chrome/browser/sync_file_system/remote_change_processor.h#newcode22 chrome/browser/sync_file_system/remote_change_processor.h:22: namespace ...
7 years, 10 months ago (2013-02-21 07:00:03 UTC) #6
calvinlo
Ok thanks for the quick reviews. After the first migration lands I'll rebase and then ...
7 years, 10 months ago (2013-02-21 07:13:27 UTC) #7
tzik
lgtm
7 years, 10 months ago (2013-02-22 09:57:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calvinlo@chromium.org/12315004/6031
7 years, 10 months ago (2013-02-22 10:15:28 UTC) #9
commit-bot: I haz the power
7 years, 10 months ago (2013-02-22 13:38:30 UTC) #10
Message was sent while issue was closed. 
Change committed as 184102

Powered by Google App Engine
This is Rietveld 408576698