[MIPS] Update the toolchain script with packages for Chromium

[MIPS] Update the toolchain script with packages for Chromium

The script is updated to be able to produce the tarball for Chromium
build. Depending on the input <nacl_sdk|chrome_sdk>, tarball for
standalone native client or Chromium build will be created.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=2275
TEST= run trusted-toolchain-creator.mipsel.squeeze.sh chrome_sdk

Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=10978

[Mark Seaborn, 2013-02-20 03:43:51]

Won't this make the toolchain tarball huge?  At some point we will probably want
to pull the MIPS trusted toolchain into the standard NaCl checkout (once the
MIPS build works minimally), and then we won't want this tarball to be bigger
than necessary.

[petarj, 2013-02-20 22:48:21]

On 2013/02/20 03:43:51, Mark Seaborn wrote:
> Won't this make the toolchain tarball huge?  At some point we will probably
want
> to pull the MIPS trusted toolchain into the standard NaCl checkout (once the
> MIPS build works minimally), and then we won't want this tarball to be bigger
> than necessary.

True, it will be bigger, though from reading install-arm-sysroot.py in
Chromium src/build/linux/, there is a comment

"# The sysroot image could be constructed from scratch based on the current
# state or precise/arm but for consistency we currently use a pre-built root
# image which was originally designed for building trusted NaCl code. The image
# will normally need to be rebuilt every time chrome's build dependancies are
# changed."

so, some may assume that you would like to have one tarball for both occasions.

We plan to create very similar install-mipsel-sysroot.py and put it in
Chromium's
src/build/linux/ folder.

I have just updated the patch, so depending on the input string, it will create
either smaller NaCl-relevant tarball, or a larger Chromium root.

[petarj, 2013-02-28 00:21:30]

On 2013/02/20 22:48:21, petarj wrote:
> On 2013/02/20 03:43:51, Mark Seaborn wrote:
> > Won't this make the toolchain tarball huge?  At some point we will probably
> want
> > to pull the MIPS trusted toolchain into the standard NaCl checkout (once the
> > MIPS build works minimally), and then we won't want this tarball to be
bigger
> > than necessary.
> 
> True, it will be bigger, though from reading install-arm-sysroot.py in
> Chromium src/build/linux/, there is a comment
> 
> "# The sysroot image could be constructed from scratch based on the current
> # state or precise/arm but for consistency we currently use a pre-built root
> # image which was originally designed for building trusted NaCl code. The
image
> # will normally need to be rebuilt every time chrome's build dependancies are
> # changed."
> 
> so, some may assume that you would like to have one tarball for both
occasions.
> 
> We plan to create very similar install-mipsel-sysroot.py and put it in
> Chromium's
> src/build/linux/ folder.
> 
> I have just updated the patch, so depending on the input string, it will
create
> either smaller NaCl-relevant tarball, or a larger Chromium root.

ping

[Mark Seaborn, 2013-02-28 20:40:28]

petarj wrote:
> On 2013/02/20 03:43:51, Mark Seaborn wrote:
> > Won't this make the toolchain tarball huge?  At some point we will
> > probably want to pull the MIPS trusted toolchain into the standard
> > NaCl checkout (once the MIPS build works minimally), and then we
> > won't want this tarball to be bigger than necessary.
>
> True, it will be bigger, though from reading install-arm-sysroot.py
> in Chromium src/build/linux/, there is a comment
>
> "# The sysroot image could be constructed from scratch based on the current
> # state or precise/arm but for consistency we currently use a pre-built root
> # image which was originally designed for building trusted NaCl code. The
image
> # will normally need to be rebuilt every time chrome's build dependancies are
> # changed."

I don't like that we're putting knowledge about Chromium's build
dependencies into the NaCl repo.  It duplicates the list that lives in
Chromium's build/install-build-deps.sh.  It would be much better to
make that list reusable and make it a parameter to your script.

That said, I won't hold up your change if you do the cleanups below.


> so, some may assume that you would like to have one tarball for both
> occasions.
>
> We plan to create very similar install-mipsel-sysroot.py and put it
> in Chromium's src/build/linux/ folder.

I suspect it would be more appropriate to rename
install-arm-sysroot.py to install-sysroot.py and add MIPS support to
it.  The ARM support code is really cross-compile support code, and as
such it doesn't make sense to be duplicating it all the time.

Duplicating code was appropriate for NaCl's service_runtime/arch/
subdir, but elsewhere it creates code that's a pain to keep in sync
and is likely to bitrot because few people run it.

https://codereview.chromium.org/12315003/diff/3001/tools/trusted_cross_toolch...
File tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh
(right):

https://codereview.chromium.org/12315003/diff/3001/tools/trusted_cross_toolch...
tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh:81:
echo "$0 <trusted_sdk|chrome_sdk>"
The "trusted" vs. "chrome" naming doesn't really make sense.  Both are trusted. 
"nacl" vs. "chrome" would make more sense.

https://codereview.chromium.org/12315003/diff/3001/tools/trusted_cross_toolch...
tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh:481:
libx11-dev \
NaCl doesn't depend on X11, so can you move this to the Chrome list too, as you
did with libasound?

https://codereview.chromium.org/12315003/diff/3001/tools/trusted_cross_toolch...
tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh:489:
readonly CHROME_PACKAGES="\
Maybe you could move these lists to live in text files?  Then it will be easier
to share them between scripts.  The ARM version puts the lists in text files, in
*.base and *.extra (though as pathnames rather than the cleaner package names
you're using).

https://codereview.chromium.org/12315003/diff/3001/tools/trusted_cross_toolch...
tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh:788:
InstallMissingLibraries
Duplicating this list of actions is rather icky.  You're omitting
InstallTrustedLinkerScript and BuildAndInstallQemu.  Why not just do those two,
so that chrome_sdk is a superset of the NaCl version?  Or unify the two and put
those steps inside an "if"?

[petarj, 2013-03-06 00:32:10]

Third patch uploaded.

https://codereview.chromium.org/12315003/diff/3001/tools/trusted_cross_toolch...
File tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh
(right):

https://codereview.chromium.org/12315003/diff/3001/tools/trusted_cross_toolch...
tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh:81:
echo "$0 <trusted_sdk|chrome_sdk>"
On 2013/02/28 20:40:28, Mark Seaborn wrote:
> The "trusted" vs. "chrome" naming doesn't really make sense.  Both are
trusted. 
> "nacl" vs. "chrome" would make more sense.

Done. It's "nacl_sdk" vs "chrome_sdk" now.

https://codereview.chromium.org/12315003/diff/3001/tools/trusted_cross_toolch...
tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh:481:
libx11-dev \
On 2013/02/28 20:40:28, Mark Seaborn wrote:
> NaCl doesn't depend on X11, so can you move this to the Chrome list too, as
you
> did with libasound?

Done. Maybe you will want to change it for ARM too.

https://codereview.chromium.org/12315003/diff/3001/tools/trusted_cross_toolch...
tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh:489:
readonly CHROME_PACKAGES="\
On 2013/02/28 20:40:28, Mark Seaborn wrote:
> Maybe you could move these lists to live in text files?  Then it will be
easier
> to share them between scripts.  The ARM version puts the lists in text files,
in
> *.base and *.extra (though as pathnames rather than the cleaner package names
> you're using).
The change has been made so

packagelist.squeeze.mipsel.base
packagelist.squeeze.mipsel.extra

are created now.

https://codereview.chromium.org/12315003/diff/3001/tools/trusted_cross_toolch...
tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh:788:
InstallMissingLibraries
On 2013/02/28 20:40:28, Mark Seaborn wrote:
> Duplicating this list of actions is rather icky.  You're omitting
> InstallTrustedLinkerScript and BuildAndInstallQemu.  Why not just do those
two,
> so that chrome_sdk is a superset of the NaCl version?  Or unify the two and
put
> those steps inside an "if"?

Done.

[Mark Seaborn, 2013-03-06 00:43:43]

https://codereview.chromium.org/12315003/diff/3001/tools/trusted_cross_toolch...
File tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh
(right):

https://codereview.chromium.org/12315003/diff/3001/tools/trusted_cross_toolch...
tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh:489:
readonly CHROME_PACKAGES="\
On 2013/03/06 00:32:10, petarj wrote:
> On 2013/02/28 20:40:28, Mark Seaborn wrote:
> > Maybe you could move these lists to live in text files?  Then it
> > will be easier to share them between scripts.  The ARM version
> > puts the lists in text files, in *.base and *.extra (though as
> > pathnames rather than the cleaner package names you're using).

> The change has been made so
> 
> packagelist.squeeze.mipsel.base
> packagelist.squeeze.mipsel.extra
> 
> are created now.

What I meant was: can you move the lists of packages to live in checked-in text
files, not text files that are generated at run time by the script?

https://codereview.chromium.org/12315003/diff/9001/tools/trusted_cross_toolch...
File tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh
(right):

https://codereview.chromium.org/12315003/diff/9001/tools/trusted_cross_toolch...
tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh:86:
echo "chrome_sdk  - Build chrome toolchain and package it"
Nit: put only one space before "-" (be consistent)

[petarj, 2013-03-07 23:59:50]

> What I meant was: can you move the lists of packages to live in checked-in
text
> files, not text files that are generated at run time by the script?

Done.

https://codereview.chromium.org/12315003/diff/9001/tools/trusted_cross_toolch...
File tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh
(right):

https://codereview.chromium.org/12315003/diff/9001/tools/trusted_cross_toolch...
tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh:86:
echo "chrome_sdk  - Build chrome toolchain and package it"
On 2013/03/06 00:43:43, Mark Seaborn wrote:
> Nit: put only one space before "-" (be consistent)

Done.

[petarj, 2013-03-12 22:41:05]

On 2013/03/07 23:59:50, petarj wrote:

Ping.

[Mark Seaborn, 2013-03-12 23:13:42]

LGTM

https://codereview.chromium.org/12315003/diff/14001/tools/trusted_cross_toolc...
File tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh
(right):

https://codereview.chromium.org/12315003/diff/14001/tools/trusted_cross_toolc...
tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh:2: #
Copyright (c) 2013 The Native Client Authors. All rights reserved.
The policy is not to update copyright years any more.

[petarj, 2013-03-12 23:50:07]

https://codereview.chromium.org/12315003/diff/14001/tools/trusted_cross_toolc...
File tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh
(right):

https://codereview.chromium.org/12315003/diff/14001/tools/trusted_cross_toolc...
tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh:2: #
Copyright (c) 2013 The Native Client Authors. All rights reserved.
On 2013/03/12 23:13:42, Mark Seaborn wrote:
> The policy is not to update copyright years any more.

Done.

[commit-bot: I haz the power, 2013-03-12 23:50:24]

CQ is trying da patch. Follow status at
https://nativeclient-status.appspot.com/cq/petarj@mips.com/12315003/21001

[commit-bot: I haz the power, 2013-03-12 23:50:26]

Presubmit check for 12315003-21001 failed and returned exit status 1.

INFO:root:Found 3 file(s).
Running presubmit commit checks ...
Running /b/commit-queue/workdir/nacl/PRESUBMIT.py

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh,
line 479, 85 chars \
  tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh,
line 480, 87 chars

[commit-bot: I haz the power, 2013-03-13 15:52:36]

CQ is trying da patch. Follow status at
https://nativeclient-status.appspot.com/cq/petarj@mips.com/12315003/27001

[commit-bot: I haz the power, 2013-03-13 17:51:29]

Change committed as 10978