Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 12314144: Wrong file/dir owner and permission for installed Chrome OS fonts (Closed)

Created:
7 years, 9 months ago by sschmitz
Modified:
7 years, 9 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Wrong file/dir owner and permission for installed Chrome OS fonts The install script sets owner to root and adjust dir/file permissions to 0755 and 0644 respectively. BUG=178612 TEST=manual; inspect dir/file owner and permissions in /usr/local/share/fonts/chromeos. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184986

Patch Set 1 #

Patch Set 2 : 178612 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M build/linux/install-chromeos-fonts.py View 1 3 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sschmitz
Dan: in last weeks Chrome OS font installation script, I forgot to adjust ownership and ...
7 years, 9 months ago (2013-02-27 03:31:57 UTC) #1
Daniel Erat
lgtm
7 years, 9 months ago (2013-02-27 06:12:48 UTC) #2
sschmitz
One more thing: I changed the name of the stamp file to force an update ...
7 years, 9 months ago (2013-02-27 15:59:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sschmitz@chromium.org/12314144/3
7 years, 9 months ago (2013-02-27 15:59:36 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2013-02-27 18:03:24 UTC) #5
Message was sent while issue was closed.
Change committed as 184986

Powered by Google App Engine
This is Rietveld 408576698