Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 12314118: [Android] Fix v8_shell compilation for Android component build. (Closed)

Created:
7 years, 10 months ago by Yaron
Modified:
7 years, 10 months ago
Reviewers:
ulan
Base URL:
https://chromium.googlesource.com/external/v8.git@master
Visibility:
Public.

Description

[Android] Fix v8_shell compilation for Android component build. r12883 was in complete because the library was included for host and target. Restrict to just target. BUG=chromium:158821 Committed: https://code.google.com/p/v8/source/detail?r=13734

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tools/gyp/v8.gyp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yaron
7 years, 10 months ago (2013-02-26 01:51:45 UTC) #1
ulan
LGTM, I will land this for you.
7 years, 10 months ago (2013-02-26 15:40:31 UTC) #2
ulan
Committed patchset #1 manually as r13734 (presubmit successful).
7 years, 10 months ago (2013-02-26 15:41:09 UTC) #3
Yaron
7 years, 10 months ago (2013-02-26 17:42:33 UTC) #4
Message was sent while issue was closed.
Thanks!

Powered by Google App Engine
This is Rietveld 408576698