Issue 12314093: Capture the exit status of the first-run AutoImport and make it available to tests.

Issue 12314093: Capture the exit status of the first-run AutoImport and make it available to tests. (Closed)

Created:
7 years, 10 months ago by tapted

Modified:
7 years, 9 months ago

Reviewers:
cpu_(ooo_6.6-7.5), sail

CC:
chromium-reviews, rginda+watch_chromium.org, sail+watch_chromium.org, Andrew T Wilson (Slow), chrome-apps-syd-reviews_chromium.org, gab

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Capture the exit status of the first-run AutoImport and make it available to tests. This allows a CHECK() or other failure in the Import process to trigger a test failure when run during automated testing. BUG=174866 TEST=browser_tests: FirstRunIntegrationBrowserTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184807

Patch Set 1 #

Patch Set 2 : Disable WaitForImport on Linux #

Total comments: 2

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -18 lines)			Patch
M	chrome/browser/first_run/first_run.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/first_run/first_run.cc	View		4 chunks	+15 lines, -1 line	0 comments	Download
M	chrome/browser/first_run/first_run_browsertest.cc	View	1	3 chunks	+19 lines, -4 lines	2 comments	Download
M	chrome/browser/profiles/profile_manager.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/profiles/profile_manager.cc	View		2 chunks	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

tapted

cpu: please take a look for c/b/first_run changes sail: for code leaving c/b/profiles atwilson: FYI

7 years, 10 months ago (2013-02-25 11:17:52 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/12314093/7001

7 years, 10 months ago (2013-02-26 22:17:09 UTC) #4

gab

FYI https://codereview.chromium.org/12314093/diff/7001/chrome/browser/first_run/first_run_browsertest.cc File chrome/browser/first_run/first_run_browsertest.cc (right): https://codereview.chromium.org/12314093/diff/7001/chrome/browser/first_run/first_run_browsertest.cc#newcode123 chrome/browser/first_run/first_run_browsertest.cc:123: // TODO(tapted): Investigate why this fails on Linux ...

7 years, 9 months ago (2013-03-07 15:35:49 UTC) #6

gab

7 years, 9 months ago (2013-03-07 15:53:18 UTC) #7

Message was sent while issue was closed.

https://codereview.chromium.org/12314093/diff/7001/chrome/browser/first_run/f...
File chrome/browser/first_run/first_run_browsertest.cc (right):

https://codereview.chromium.org/12314093/diff/7001/chrome/browser/first_run/f...
chrome/browser/first_run/first_run_browsertest.cc:123: // TODO(tapted):
Investigate why this fails on Linux bots but does not
On 2013/03/07 15:35:49, gab wrote:
> Perhaps this was the same issue I fixed in http://crrev.com/186367?

Meh, nvm, this fix was win only.

Expand Messages | Collapse Messages