Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5397)

Unified Diff: chrome/browser/extensions/api/alarms/alarms_api.h

Issue 12314056: Make chrome/browser/extensions use base::Clock instead of MockTimeProvider (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add include Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/alarms/alarms_api.h
diff --git a/chrome/browser/extensions/api/alarms/alarms_api.h b/chrome/browser/extensions/api/alarms/alarms_api.h
index eb521aa0ff7746aceb6a2b175a1b649101489c2c..bc694fff2073dcbdad5621a1e91ec21d99f6b11a 100644
--- a/chrome/browser/extensions/api/alarms/alarms_api.h
+++ b/chrome/browser/extensions/api/alarms/alarms_api.h
@@ -7,21 +7,30 @@
#include "chrome/browser/extensions/extension_function.h"
+namespace base {
+class Clock;
+} // namespace base
+
namespace extensions {
class AlarmsCreateFunction : public SyncExtensionFunction {
- typedef base::Time (*TimeProvider)();
public:
AlarmsCreateFunction();
- explicit AlarmsCreateFunction(TimeProvider now) : now_(now) {}
+ // Use |clock| instead of the default clock. Does not take ownership
+ // of |clock|. Used for testing.
+ explicit AlarmsCreateFunction(base::Clock* clock);
protected:
- virtual ~AlarmsCreateFunction() {}
+ virtual ~AlarmsCreateFunction();
// ExtensionFunction:
virtual bool RunImpl() OVERRIDE;
DECLARE_EXTENSION_FUNCTION("alarms.create", ALARMS_CREATE)
private:
- TimeProvider now_;
+ base::Clock* const clock_;
+ // Whether or not we own |clock_|. This is needed because we own it
+ // when we create it ourselves, but not when it's passed in for
+ // testing.
+ bool owns_clock_;
};
class AlarmsGetFunction : public SyncExtensionFunction {
« no previous file with comments | « chrome/browser/extensions/api/alarms/alarm_manager.cc ('k') | chrome/browser/extensions/api/alarms/alarms_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698