Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: presubmit_canned_checks.py

Issue 12314044: return a list of uncovered files, not uncovered dirs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: fix formatting Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « owners.py ('k') | tests/owners_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: presubmit_canned_checks.py
diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py
index f3f757a9e093d4df84093e7079e25b983ec949d8..2a6f8fd383861d66ddf98bea6db61f63c639a678 100644
--- a/presubmit_canned_checks.py
+++ b/presubmit_canned_checks.py
@@ -797,16 +797,16 @@ def CheckOwners(input_api, output_api, source_file_filter=None):
reviewers_plus_owner = reviewers.union(set([owner_email]))
else:
message = ('\nUntil the issue is uploaded, this list will include '
- 'directories for which you \nare an OWNER.')
+ 'files for which you are an OWNER.')
owner_email = ''
reviewers_plus_owner = set()
- missing_directories = owners_db.directories_not_covered_by(affected_files,
- reviewers_plus_owner)
- if missing_directories:
+ missing_files = owners_db.files_not_covered_by(affected_files,
+ reviewers_plus_owner)
+ if missing_files:
output_list = [
- output('Missing %s for files in these directories:\n %s%s' %
- (needed, '\n '.join(missing_directories), message))]
+ output('Missing %s for these files:\n %s%s' %
+ (needed, '\n '.join(missing_files), message))]
if not input_api.is_committing:
suggested_owners = owners_db.reviewers_for(affected_files)
output_list.append(output('Suggested OWNERS:\n %s' %
« no previous file with comments | « owners.py ('k') | tests/owners_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698