Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 12314044: return a list of uncovered files, not uncovered dirs (Closed)

Created:
7 years, 10 months ago by Dirk Pranke
Modified:
7 years, 10 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Visibility:
Public.

Description

Change the OWNERS check to print files, not directories Currently, when we run the OWNERS check, we print the list of directories that contain the relevant OWNERS files for any modified files in a change still needing approval. This has two problems: 1) if we bubble all the way up to the top level OWNERS, we print "" instead of "src/" or something more useful (bug 157191) 2) for OWNERS files that contain per-file set-noparent entries (like changes to IPC messages), this can be really confusing because an owner of other stuff in the directory might've approved things already. This change will now print the list of files in the CL that are still unapproved. This might be a lot more verbose (since you get N lines rather than 1 for N files in a given directory), but hopefully it'll be clearer in the two cases above. Also, this change takes care of some lingering clean-up in the code to rename some methods to be clearer. R=maruel@chromium.org BUG=157191 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=184219

Patch Set 1 #

Patch Set 2 : fix formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -107 lines) Patch
M owners.py View 1 3 chunks +17 lines, -40 lines 0 comments Download
M presubmit_canned_checks.py View 1 chunk +6 lines, -6 lines 0 comments Download
M tests/owners_unittest.py View 5 chunks +40 lines, -40 lines 0 comments Download
M tests/presubmit_unittest.py View 4 chunks +17 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dirk Pranke
7 years, 10 months ago (2013-02-21 20:50:50 UTC) #1
M-A Ruel
lgtm
7 years, 10 months ago (2013-02-22 14:12:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/12314044/2001
7 years, 10 months ago (2013-02-23 00:04:04 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-02-23 00:06:40 UTC) #4
Message was sent while issue was closed.
Change committed as 184219

Powered by Google App Engine
This is Rietveld 408576698