Make Ash unittests clean up zombie viewer processes between test runs. These zombie viewer proce…

Make Ash unittests clean up zombie viewer processes between test runs. These zombie viewer processes seem to be a side effect of attempting to quit a metro app while the same app is activating. *while here can mean within a certain number of seconds due to metro life cycle management.

Refactor KillAllNamedProcessesWithArgument into base/test.

BUG=154081
TEST=Run "ash_unittests.exe --ash-metro-tests" on Win8. Observe that 417 chrome.exe processes do not get created :)


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184413

[robertshield, 2013-02-21 19:37:34]

PTAL, thanks!

Ananta -> chrome_frame/
Brett -> base/
Scott -> ash/

[ananta, 2013-02-22 19:17:02]

ChromeFrame changes LGTM

[brettw, 2013-02-22 20:31:01]

I'm trying hard to avoid _util files since you have no idea looking at a listing
what it does. Can we call it something more specific kill_test_processes or
something? (feel free to suggest something better).

Also, please use base namespace for all code in base now.

https://codereview.chromium.org/12314043/diff/2002/base/test/test_process_uti...
File base/test/test_process_util_win.h (right):

https://codereview.chromium.org/12314043/diff/2002/base/test/test_process_uti...
base/test/test_process_util_win.h:11: // |argument| on their command line.
Useful for killing all Chrome Frame
Please fix comment not to reference C.F.

[robertshield, 2013-02-22 21:10:41]

Thanks Brett, renamed files, added namespace, changed comment. PTAL

https://codereview.chromium.org/12314043/diff/2002/base/test/test_process_uti...
File base/test/test_process_util_win.h (right):

https://codereview.chromium.org/12314043/diff/2002/base/test/test_process_uti...
base/test/test_process_util_win.h:11: // |argument| on their command line.
Useful for killing all Chrome Frame
On 2013/02/22 20:31:02, brettw wrote:
> Please fix comment not to reference C.F.

Done.

[brettw, 2013-02-22 21:21:24]

base addition LGTM, but I didn't look at the added code at all.

[sky, 2013-02-22 21:24:49]

LGTM

[commit-bot: I haz the power, 2013-02-22 21:56:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertshield@chromium.org/12314043/16

[commit-bot: I haz the power, 2013-02-22 23:44:02]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-02-25 02:46:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertshield@chromium.org/12314043/14005

[commit-bot: I haz the power, 2013-02-25 04:00:55]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-02-25 13:37:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertshield@chromium.org/12314043/14005

[commit-bot: I haz the power, 2013-02-25 16:01:46]

Change committed as 184413

[Timur Iskhodzhanov, 2013-03-18 22:28:47]

https://chromiumcodereview.appspot.com/12314043/diff/14005/base/test/test_pro...
File base/test/test_process_killer_win.cc (right):

https://chromiumcodereview.appspot.com/12314043/diff/14005/base/test/test_pro...
base/test/test_process_killer_win.cc:162: return
base::KillProcesses(process_name, 0, &ArgumentFilter(argument));
I think this is a buggy line:
http://crbug.com/219360

[robertshield, 2013-03-19 00:25:22]

On 2013/03/18 22:28:47, Timur Iskhodzhanov wrote:
>
https://chromiumcodereview.appspot.com/12314043/diff/14005/base/test/test_pro...
> File base/test/test_process_killer_win.cc (right):
> 
>
https://chromiumcodereview.appspot.com/12314043/diff/14005/base/test/test_pro...
> base/test/test_process_killer_win.cc:162: return
> base::KillProcesses(process_name, 0, &ArgumentFilter(argument));
> I think this is a buggy line:
> http://crbug.com/219360

I believe MSVC allows this (it's a non-standard compiler extension). I'll
standard-ify it in a follow up CL.