Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12314041: Make all tests in drt run at once (Closed)

Created:
7 years, 10 months ago by Siggi Cherem (dart-lang)
Modified:
7 years, 10 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org, web-ui-dev+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/web-ui.git@master
Visibility:
Public.

Description

Make all tests in drt run at once Committed: https://github.com/dart-lang/web-ui/commit/43135f9

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -118 lines) Patch
M test/data/expected/attr_multiple_bindings_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/bind_hyphenated_attribute_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/bootstrap_path_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/code_in_dart_file_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/component_field_2way_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/component_field_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/component_imports_component2_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/component_imports_component3_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/component_imports_component_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/component_in_main_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/component_inherit_noscript_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/component_inherit_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/component_unique_ids_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/conditional2_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/conditional3_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/conditional4_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/conditional5_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/conditional_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/constant_argument_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/css_classes_binding_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/custom_radio_button_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/dom_accessor_binding2_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/dom_accessor_binding_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/duplicate_event_listeners_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/element_ctor_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/empty2_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/empty_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/ensure_parent_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/escape2_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/escape_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/escape_uri_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/final_one_time_binding_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/html_escape_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/if_attribute_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/if_children_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/if_fragments2_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/if_fragments3_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/if_fragments4_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/if_fragments_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/iterate_attribute_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/iterate_fragments_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/list2_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/list3_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/list4_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/list5_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/list6_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/list_children_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/list_component_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/list_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/main_code_in_dart_file_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/mix_iterate_if_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/news_index_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/observable_import_normal_code_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/omit_main_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/path_normalization_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/query_in_main_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/radio_button_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/recursive_component_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/root_query_no_shadowroot_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/style_binding_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/table_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/template_multiple_children_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/template_zero_children_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/text_multiple_bindings_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/text_top_level2_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/text_top_level_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/text_tostring_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/todomvc_listorder_shadowdom_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/todomvc_listorder_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/todomvc_mainpage2_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/todomvc_mainpage_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/todomvc_markdone_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/trim_indentation_space_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/watch_global_var2_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/watch_global_var3_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/data/expected/watch_global_var_test.html.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/run_all.dart View 1 2 chunks +113 lines, -42 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Siggi Cherem (dart-lang)
Each invocation to DRT is expensive, now the whole test suite (without the analyzer) runs ...
7 years, 10 months ago (2013-02-21 19:22:24 UTC) #1
Jennifer Messerly
lgtm! https://chromiumcodereview.appspot.com/12314041/diff/79/test/run_all.dart File test/run_all.dart (right): https://chromiumcodereview.appspot.com/12314041/diff/79/test/run_all.dart#newcode77 test/run_all.dart:77: expect(Process.run('DumpRenderTree', inputPaths).then((res) { interesting, so you can just ...
7 years, 10 months ago (2013-02-21 20:42:36 UTC) #2
Siggi Cherem (dart-lang)
On 2013/02/21 20:42:36, John Messerly wrote: > lgtm! > > https://chromiumcodereview.appspot.com/12314041/diff/79/test/run_all.dart > File test/run_all.dart (right): ...
7 years, 10 months ago (2013-02-21 20:44:49 UTC) #3
Siggi Cherem (dart-lang)
7 years, 10 months ago (2013-02-21 20:45:54 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r43135f9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698