Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 12314025: Add gyp flag to specify whether we should optimize JNI generation. (Closed)

Created:
7 years, 10 months ago by Ted C
Modified:
7 years, 10 months ago
Reviewers:
cjhopman, Yaron, Torne
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Add gyp flag to specify whether we should optimize JNI generation. Do not regenerate JNI files (and subsequently the .so file) if they have not changed. This will happen if you edit a java file that has a native counterpart, but the native signatures were not touched. We do not enable this all the time as some build systems require that when you modify an input, the output should also be modified. This also will result in more command line output, so we'll keep it behind a developer flag for now. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183936

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M base/android/jni_generator/jni_generator.py View 4 chunks +12 lines, -2 lines 0 comments Download
M build/common.gypi View 1 1 chunk +6 lines, -0 lines 0 comments Download
M build/jar_file_jni_generator.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M build/jni_generator.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ted C
My old branch got deleted, so starting this anew.
7 years, 10 months ago (2013-02-21 02:31:23 UTC) #1
Torne
On 2013/02/21 02:31:23, Ted C wrote: > My old branch got deleted, so starting this ...
7 years, 10 months ago (2013-02-21 09:48:29 UTC) #2
Torne
lgtm
7 years, 10 months ago (2013-02-21 09:49:17 UTC) #3
Yaron
lgtm https://chromiumcodereview.appspot.com/12314025/diff/1/build/common.gypi File build/common.gypi (right): https://chromiumcodereview.appspot.com/12314025/diff/1/build/common.gypi#newcode1154 build/common.gypi:1154: # the outputs should always change as well. ...
7 years, 10 months ago (2013-02-21 18:57:33 UTC) #4
Ted C
https://chromiumcodereview.appspot.com/12314025/diff/1/build/common.gypi File build/common.gypi (right): https://chromiumcodereview.appspot.com/12314025/diff/1/build/common.gypi#newcode1154 build/common.gypi:1154: # the outputs should always change as well. On ...
7 years, 10 months ago (2013-02-21 19:01:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/12314025/2003
7 years, 10 months ago (2013-02-21 19:04:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/12314025/2003
7 years, 10 months ago (2013-02-21 22:13:29 UTC) #7
commit-bot: I haz the power
7 years, 10 months ago (2013-02-22 00:37:34 UTC) #8
Message was sent while issue was closed.
Change committed as 183936

Powered by Google App Engine
This is Rietveld 408576698