chrome/browser/profiles/profile_impl_io_data.cc - Issue 12314015: Make SQLitePersistentCookieStore run on injected SequencedTaskRunners vs named BrowserThreads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_impl_io_data.cc

Issue 12314015: Make SQLitePersistentCookieStore run on injected SequencedTaskRunners vs named BrowserThreads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Relax a newly introduced NOTREACHED. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/net/sqlite_persistent_cookie_store_unittest.cc ('k') | chrome/browser/safe_browsing/safe_browsing_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profiles/profile_impl_io_data.cc

diff --git a/chrome/browser/profiles/profile_impl_io_data.cc b/chrome/browser/profiles/profile_impl_io_data.cc

index ac66d6a988d100439d108dc1a042b5cb83aeb531..0535f1072eb7bae85e96b15f83caa5f16adab4a6 100644

--- a/chrome/browser/profiles/profile_impl_io_data.cc

+++ b/chrome/browser/profiles/profile_impl_io_data.cc

@@ -388,6 +388,8 @@ void ProfileImplIOData::InitializeInternal(

scoped_refptr<SQLitePersistentCookieStore> cookie_db =

new SQLitePersistentCookieStore(

lazy_params_->cookie_path,

+ BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO),

+ BrowserThread::GetMessageLoopProxyForThread(BrowserThread::DB),

lazy_params_->restore_old_session_cookies,

new ClearOnExitPolicy(lazy_params_->special_storage_policy));

cookie_store =

@@ -496,6 +498,8 @@ void ProfileImplIOData::

new net::CookieMonster(

new SQLitePersistentCookieStore(

lazy_params_->extensions_cookie_path,

+ BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO),

+ BrowserThread::GetMessageLoopProxyForThread(BrowserThread::DB),

lazy_params_->restore_old_session_cookies, NULL), NULL);

// Enable cookies for devtools and extension URLs.

const char* schemes[] = {chrome::kChromeDevToolsScheme,

@@ -592,7 +596,12 @@ ProfileImplIOData::InitializeAppRequestContext(

DCHECK(!cookie_path.empty());

scoped_refptr<SQLitePersistentCookieStore> cookie_db =

- new SQLitePersistentCookieStore(cookie_path, false, NULL);

+ new SQLitePersistentCookieStore(

+ cookie_path,

+ BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO),

+ BrowserThread::GetMessageLoopProxyForThread(BrowserThread::DB),

+ false,

+ NULL);

// TODO(creis): We should have a cookie delegate for notifying the cookie

// extensions API, but we need to update it to understand isolated apps

// first.