Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1755)

Side by Side Diff: chrome/browser/ui/ash/shelf_browsertest.cc

Issue 12313118: Refactor: Shelf Widget (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: safer shutdown (status_area_widget_) Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/root_window_controller.h" 5 #include "ash/root_window_controller.h"
6 #include "ash/shelf/shelf_layout_manager.h"
6 #include "ash/shell.h" 7 #include "ash/shell.h"
7 #include "ash/wm/shelf_layout_manager.h"
8 #include "ash/wm/workspace_controller.h" 8 #include "ash/wm/workspace_controller.h"
9 #include "base/utf_string_conversions.h" 9 #include "base/utf_string_conversions.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
11 #include "chrome/browser/ui/browser_window.h" 11 #include "chrome/browser/ui/browser_window.h"
12 #include "chrome/browser/ui/status_bubble.h" 12 #include "chrome/browser/ui/status_bubble.h"
13 #include "chrome/test/base/in_process_browser_test.h" 13 #include "chrome/test/base/in_process_browser_test.h"
14 14
15 typedef InProcessBrowserTest ShelfBrowserTest; 15 typedef InProcessBrowserTest ShelfBrowserTest;
16 16
17 // Confirm that a status bubble doesn't cause the shelf to darken. 17 // Confirm that a status bubble doesn't cause the shelf to darken.
18 IN_PROC_BROWSER_TEST_F(ShelfBrowserTest, StatusBubble) { 18 IN_PROC_BROWSER_TEST_F(ShelfBrowserTest, StatusBubble) {
19 ash::internal::ShelfLayoutManager* shelf = 19 ash::internal::ShelfLayoutManager* shelf =
20 ash::internal::RootWindowController::ForLauncher( 20 ash::internal::RootWindowController::ForLauncher(
21 browser()->window()->GetNativeWindow())->shelf(); 21 browser()->window()->GetNativeWindow())->GetShelfLayoutManager();
22 EXPECT_TRUE(shelf->IsVisible()); 22 EXPECT_TRUE(shelf->IsVisible());
23 23
24 // Ensure that the browser abuts the shelf. 24 // Ensure that the browser abuts the shelf.
25 const gfx::Rect old_bounds = browser()->window()->GetBounds(); 25 const gfx::Rect old_bounds = browser()->window()->GetBounds();
26 const gfx::Rect new_bounds( 26 const gfx::Rect new_bounds(
27 old_bounds.x(), 27 old_bounds.x(),
28 old_bounds.y(), 28 old_bounds.y(),
29 old_bounds.width(), 29 old_bounds.width(),
30 shelf->GetIdealBounds().y() - old_bounds.y()); 30 shelf->GetIdealBounds().y() - old_bounds.y());
31 browser()->window()->SetBounds(new_bounds); 31 browser()->window()->SetBounds(new_bounds);
32 EXPECT_FALSE(shelf->window_overlaps_shelf()); 32 EXPECT_FALSE(shelf->window_overlaps_shelf());
33 33
34 // Show status, which will overlap the shelf by a pixel. 34 // Show status, which will overlap the shelf by a pixel.
35 browser()->window()->GetStatusBubble()->SetStatus( 35 browser()->window()->GetStatusBubble()->SetStatus(
36 UTF8ToUTF16("Dummy Status Text")); 36 UTF8ToUTF16("Dummy Status Text"));
37 shelf->UpdateVisibilityState(); 37 shelf->UpdateVisibilityState();
38 38
39 // Ensure that status doesn't cause overlap. 39 // Ensure that status doesn't cause overlap.
40 EXPECT_FALSE(shelf->window_overlaps_shelf()); 40 EXPECT_FALSE(shelf->window_overlaps_shelf());
41 } 41 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698