Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1352)

Issue 12313068: net: add basic ChannelID support to TLSLite. (Closed)

Created:
7 years, 10 months ago by agl
Modified:
7 years, 9 months ago
CC:
chromium-reviews, trevp, Ryan Sleevi
Visibility:
Public.

Description

net: add basic ChannelID support to TLSLite. In order to test some ChannelID functions, this change adds basic ChannelID support to testserver and TLSLite. With this change, testserver can receive a ChannelID and echo its hash on /channel-id. This code doesn't check the ChannelID signature. BUG=none TBR=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185744

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -3 lines) Patch
M net/tools/testserver/testserver.py View 3 chunks +15 lines, -0 lines 0 comments Download
M third_party/tlslite/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/tlslite/patches/channel_id.patch View 1 chunk +217 lines, -0 lines 0 comments Download
M third_party/tlslite/tlslite/TLSConnection.py View 7 chunks +23 lines, -2 lines 0 comments Download
M third_party/tlslite/tlslite/TLSRecordLayer.py View 3 chunks +12 lines, -1 line 0 comments Download
M third_party/tlslite/tlslite/constants.py View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/tlslite/tlslite/messages.py View 6 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
agl
juanlang requested some help with testing ChannelIDs in Chromium. juanlang: is this a reasonable start ...
7 years, 10 months ago (2013-02-22 19:25:43 UTC) #1
Ryan Sleevi
I added Trevor (upstream TLSlite maintainer/author) as a CC as an FYI. I'd really like ...
7 years, 10 months ago (2013-02-22 19:29:33 UTC) #2
juanlang
On 2013/02/22 19:29:33, Ryan Sleevi wrote: > I added Trevor (upstream TLSlite maintainer/author) as a ...
7 years, 10 months ago (2013-02-22 21:35:23 UTC) #3
agl
On Fri, Feb 22, 2013 at 4:35 PM, <juanlang@google.com> wrote: > I can certainly try ...
7 years, 10 months ago (2013-02-22 21:42:23 UTC) #4
Ryan Sleevi
Fair enough re: upstream. My desire to get us sync'd with upstream is to get ...
7 years, 10 months ago (2013-02-22 21:45:38 UTC) #5
Ryan Sleevi
akalin: ping
7 years, 9 months ago (2013-02-28 22:15:50 UTC) #6
akalin
testserver stuff lgtm
7 years, 9 months ago (2013-02-28 22:21:39 UTC) #7
agl
sleevi: I think this should land since we have someone willing to write tests using ...
7 years, 9 months ago (2013-03-02 00:07:45 UTC) #8
Ryan Sleevi
Oh, no, my LGTM was totally gated on Fred. The upgrade to TLSLite 0.4.3/0.4.4 is ...
7 years, 9 months ago (2013-03-02 00:08:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/12313068/1
7 years, 9 months ago (2013-03-02 00:16:10 UTC) #10
commit-bot: I haz the power
Presubmit check for 12313068-1 failed and returned exit status 1. INFO:root:Found 7 file(s). Running presubmit ...
7 years, 9 months ago (2013-03-02 00:16:16 UTC) #11
Ryan Sleevi
TBR darin, per https://groups.google.com/a/chromium.org/d/topic/chromium-dev/Ynu3dDWXRcc/discussion
7 years, 9 months ago (2013-03-02 01:36:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/12313068/1
7 years, 9 months ago (2013-03-02 01:42:13 UTC) #13
agl
On Fri, Mar 1, 2013 at 5:36 PM, <rsleevi@chromium.org> wrote: > TBR darin, per > ...
7 years, 9 months ago (2013-03-02 03:19:37 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/12313068/1
7 years, 9 months ago (2013-03-02 16:06:45 UTC) #15
commit-bot: I haz the power
7 years, 9 months ago (2013-03-02 18:40:44 UTC) #16
Message was sent while issue was closed.
Change committed as 185744

Powered by Google App Engine
This is Rietveld 408576698