Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 12313067: Prevent bindings escalation on an existing NavigationEntry (attempt 3). (Closed)

Created:
7 years, 10 months ago by Charlie Reis
Modified:
7 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, marja+watch_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Prevent bindings escalation on an existing NavigationEntry (attempt 3). BUG=173672 TEST=See bug for repro steps. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184264

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -6 lines) Patch
M chrome/browser/sessions/session_restore_browsertest.cc View 2 chunks +19 lines, -0 lines 0 comments Download
M content/browser/web_contents/navigation_controller_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/web_contents/navigation_controller_impl_unittest.cc View 2 chunks +50 lines, -0 lines 0 comments Download
M content/browser/web_contents/navigation_entry_impl.h View 3 chunks +13 lines, -0 lines 0 comments Download
M content/browser/web_contents/navigation_entry_impl.cc View 4 chunks +11 lines, -0 lines 0 comments Download
M content/browser/web_contents/render_view_host_manager.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/web_contents/render_view_host_manager.cc View 4 chunks +20 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Charlie Reis
Hey Darin-- can you approve this again? It's identical to https://codereview.chromium.org/12210048. I had to revert ...
7 years, 10 months ago (2013-02-22 22:15:48 UTC) #1
darin (slow to review)
LGTM On Fri, Feb 22, 2013 at 2:15 PM, <creis@chromium.org> wrote: > Reviewers: darin, > ...
7 years, 10 months ago (2013-02-22 23:29:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/12313067/1
7 years, 10 months ago (2013-02-23 00:02:37 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-02-23 02:33:51 UTC) #4
Message was sent while issue was closed.
Change committed as 184264

Powered by Google App Engine
This is Rietveld 408576698