Installing ChromeOS font on developer Linux machine

Installing ChromeOS font on developer Linux machine

Added call to a new script in:
build/install-build-deps.sh 
to download and install the ChromeOS default font
(Noto Sans UI). The installation is in:
/usr/local/share/fonts.
ChromeOS on Linux will use the font if present.
The installation creates (or recreates) a subdir:
"chromeos". In it it creates a .stamp file which is used
to avoid re-installation if it is already up to date.
It also creates a README file.

BUG=148945
TEST=manual;
One way to test is to instrument the file:
src/ui/gfx/platform_font_pango.cc
to log default_font_->GetFontName(); in ctor
PlatformFontPango::PlatformFontPango()
Expect:
W/out font installation: DejaVu Sans
With font installation: Noto Sans UI



Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184006

[sschmitz, 2013-02-21 18:36:16]

Dan, thanks for your help.

[Daniel Erat, 2013-02-21 20:38:03]

https://codereview.chromium.org/12313039/diff/1/build/install-build-deps.sh
File build/install-build-deps.sh (right):

https://codereview.chromium.org/12313039/diff/1/build/install-build-deps.sh#n...
build/install-build-deps.sh:17: echo "--[no-]chromeos-font: enable or disable
installation of ChromeOS font"
nit: "chromeos-fonts" would probably be better, in case more get added later

https://codereview.chromium.org/12313039/diff/1/build/install-build-deps.sh#n...
build/install-build-deps.sh:208: if test "$do_inst_chromeos_font" != "0"; then
nit: echo a message like "Installing Chrome OS fonts.", since that seems to
match what's done for other options (or maybe this isn't necessary, since the
script looks like it outputs a similar message)

https://codereview.chromium.org/12313039/diff/1/build/install-build-deps.sh#n...
build/install-build-deps.sh:212: echo "Skipping installation of ChromeOS font."
nit: s/ChromeOS/Chrome OS/, s/font/fonts/

https://codereview.chromium.org/12313039/diff/1/build/linux/install-chromeos-...
File build/linux/install-chromeos-font.py (right):

https://codereview.chromium.org/12313039/diff/1/build/linux/install-chromeos-...
build/linux/install-chromeos-font.py:8: #
/work/chromium/src/build/install-build-deps.sh.
nit: don't include your own personal /work path in this comment (e.g. just say
"... as part of install-build-deps.sh." instead)

https://codereview.chromium.org/12313039/diff/1/build/linux/install-chromeos-...
build/linux/install-chromeos-font.py:17: URL_PATH = 'notofonts-20121206.tar.gz'
nit: URL_FILE would be more accurate

https://codereview.chromium.org/12313039/diff/1/build/linux/install-chromeos-...
build/linux/install-chromeos-font.py:28: return 0
return 1 for errors

https://codereview.chromium.org/12313039/diff/1/build/linux/install-chromeos-...
build/linux/install-chromeos-font.py:32: return 0
ditto here

https://codereview.chromium.org/12313039/diff/1/build/linux/install-chromeos-...
build/linux/install-chromeos-font.py:36: return 0
and here

[sschmitz, 2013-02-21 21:47:44]

I also renamed the new script name - s/font/fonts/ - in order
to be consistent. Sorry that that spoils delta viewing.

https://codereview.chromium.org/12313039/diff/1/build/install-build-deps.sh
File build/install-build-deps.sh (right):

https://codereview.chromium.org/12313039/diff/1/build/install-build-deps.sh#n...
build/install-build-deps.sh:17: echo "--[no-]chromeos-font: enable or disable
installation of ChromeOS font"
On 2013/02/21 20:38:03, Daniel Erat wrote:
> nit: "chromeos-fonts" would probably be better, in case more get added later

Done.

https://codereview.chromium.org/12313039/diff/1/build/install-build-deps.sh#n...
build/install-build-deps.sh:208: if test "$do_inst_chromeos_font" != "0"; then
On 2013/02/21 20:38:03, Daniel Erat wrote:
> nit: echo a message like "Installing Chrome OS fonts.", since that seems to
> match what's done for other options (or maybe this isn't necessary, since the
> script looks like it outputs a similar message)
For symmetry, I will add a message. That will add context info for errors. In
addition the script outputs one (of two) messages when successful. They give
more info:

Chrome OS fonts already up-to-date in /usr/local/share/fonts.

OR:

Installing Chrome OS fonts to /usr/local/share/fonts.

Done

https://codereview.chromium.org/12313039/diff/1/build/install-build-deps.sh#n...
build/install-build-deps.sh:212: echo "Skipping installation of ChromeOS font."
On 2013/02/21 20:38:03, Daniel Erat wrote:
> nit: s/ChromeOS/Chrome OS/, s/font/fonts/

Done.

https://codereview.chromium.org/12313039/diff/1/build/linux/install-chromeos-...
File build/linux/install-chromeos-font.py (right):

https://codereview.chromium.org/12313039/diff/1/build/linux/install-chromeos-...
build/linux/install-chromeos-font.py:8: #
/work/chromium/src/build/install-build-deps.sh.
On 2013/02/21 20:38:03, Daniel Erat wrote:
> nit: don't include your own personal /work path in this comment (e.g. just say
> "... as part of install-build-deps.sh." instead)

Done.

https://codereview.chromium.org/12313039/diff/1/build/linux/install-chromeos-...
build/linux/install-chromeos-font.py:17: URL_PATH = 'notofonts-20121206.tar.gz'
On 2013/02/21 20:38:03, Daniel Erat wrote:
> nit: URL_FILE would be more accurate

Done.

https://codereview.chromium.org/12313039/diff/1/build/linux/install-chromeos-...
build/linux/install-chromeos-font.py:28: return 0
On 2013/02/21 20:38:03, Daniel Erat wrote:
> return 1 for errors

Done.

https://codereview.chromium.org/12313039/diff/1/build/linux/install-chromeos-...
build/linux/install-chromeos-font.py:32: return 0
On 2013/02/21 20:38:03, Daniel Erat wrote:
> ditto here

Done.

https://codereview.chromium.org/12313039/diff/1/build/linux/install-chromeos-...
build/linux/install-chromeos-font.py:36: return 0
On 2013/02/21 20:38:03, Daniel Erat wrote:
> and here

Done.

[Daniel Erat, 2013-02-21 21:51:43]

lgtm

https://codereview.chromium.org/12313039/diff/5001/build/install-build-deps.sh
File build/install-build-deps.sh (right):

https://codereview.chromium.org/12313039/diff/5001/build/install-build-deps.s...
build/install-build-deps.sh:17: echo "--[no-]chromeos-fonts: enable or disable
installation of Chrome OS"\
nit: think you need a space before the closing double-quote, or a space on the
next line

[sschmitz, 2013-02-21 22:04:27]

Comment on nit. No change.

https://codereview.chromium.org/12313039/diff/5001/build/install-build-deps.sh
File build/install-build-deps.sh (right):

https://codereview.chromium.org/12313039/diff/5001/build/install-build-deps.s...
build/install-build-deps.sh:17: echo "--[no-]chromeos-fonts: enable or disable
installation of Chrome OS"\
On 2013/02/21 21:51:43, Daniel Erat wrote:
> nit: think you need a space before the closing double-quote, or a space on the
> next line
Actually no. Example:
% echo "abc"   "def" 
abc def

[commit-bot: I haz the power, 2013-02-21 22:13:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sschmitz@chromium.org/12313039/5001

[commit-bot: I haz the power, 2013-02-22 01:44:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sschmitz@chromium.org/12313039/5001

[commit-bot: I haz the power, 2013-02-22 03:49:22]

Change committed as 184006

[Nico, 2013-09-17 19:48:25]

https://chromiumcodereview.appspot.com/12313039/diff/5001/build/install-build...
File build/install-build-deps.sh (right):

https://chromiumcodereview.appspot.com/12313039/diff/5001/build/install-build...
build/install-build-deps.sh:215: fi
As this new script depends on curl, can you move this below all the apt-get
calls below which make sure that curl is installed?