Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 12313012: Adding a histrogram to track account missmatch for signin reauth. (Closed)

Created:
7 years, 10 months ago by jwd
Modified:
7 years, 10 months ago
CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)
Visibility:
Public.

Description

Adding a histrogram to track account missmatch for signin reauth. BUG=174728 TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184110

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M chrome/browser/ui/sync/one_click_signin_helper.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
A chrome/browser/ui/sync/signin_histogram.h View 1 chunk +23 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jwd
7 years, 10 months ago (2013-02-20 19:22:30 UTC) #1
jwd
https://codereview.chromium.org/12313012/diff/1/chrome/browser/ui/sync/one_click_signin_helper.cc File chrome/browser/ui/sync/one_click_signin_helper.cc (right): https://codereview.chromium.org/12313012/diff/1/chrome/browser/ui/sync/one_click_signin_helper.cc#newcode574 chrome/browser/ui/sync/one_click_signin_helper.cc:574: signin::HISTOGRAM_MAX); Oh wow, this is totally wrong!
7 years, 10 months ago (2013-02-20 22:41:27 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm
7 years, 10 months ago (2013-02-21 01:22:19 UTC) #3
jwd
+TBR Jam for gypi changes.
7 years, 10 months ago (2013-02-21 19:12:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jwd@chromium.org/12313012/4001
7 years, 10 months ago (2013-02-21 19:14:38 UTC) #5
jam
On 2013/02/21 19:12:29, Jesse Doherty wrote: > +TBR Jam for gypi changes. please see chrome/owners
7 years, 10 months ago (2013-02-21 20:57:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jwd@chromium.org/12313012/4001
7 years, 10 months ago (2013-02-21 22:11:49 UTC) #7
jwd
On 2013/02/21 22:11:49, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
7 years, 10 months ago (2013-02-21 22:57:00 UTC) #8
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 10 months ago (2013-02-22 00:06:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jwd@chromium.org/12313012/4001
7 years, 10 months ago (2013-02-22 14:34:33 UTC) #10
commit-bot: I haz the power
7 years, 10 months ago (2013-02-22 14:50:03 UTC) #11
Message was sent while issue was closed.
Change committed as 184110

Powered by Google App Engine
This is Rietveld 408576698