Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 12310162: Add Chrome Frame test for large page rendering. This is designed to ensure that large pages load co… (Closed)

Created:
7 years, 10 months ago by robertshield
Modified:
7 years, 9 months ago
CC:
chromium-reviews, grt+watch_chromium.org, amit, robertshield
Visibility:
Public.

Description

Add Chrome Frame test for large page rendering. This is designed to ensure that large pages load correctly in their entirety which should help catch bugs like crbug.com/178421. Also fix access violation in code used by tests to shut down IE. BUG=178421 TEST=chrome_frame_tests.exe Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185260

Patch Set 1 #

Patch Set 2 : Don't re-enable tests on IE9 (yet). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10040 lines, -1 line) Patch
M chrome_frame/test/chrome_frame_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
A chrome_frame/test/data/chrome_frame_large_page.html View 1 chunk +10028 lines, -0 lines 0 comments Download
M chrome_frame/test/test_with_web_server.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
robertshield
7 years, 10 months ago (2013-02-27 02:22:23 UTC) #1
ananta
lgtm
7 years, 10 months ago (2013-02-27 02:53:41 UTC) #2
grt (UTC plus 2)
lgtm
7 years, 9 months ago (2013-02-27 17:19:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/12310162/2001
7 years, 9 months ago (2013-02-27 17:30:25 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=116217
7 years, 9 months ago (2013-02-27 19:43:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/12310162/2001
7 years, 9 months ago (2013-02-27 19:47:55 UTC) #6
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=14620
7 years, 9 months ago (2013-02-27 23:59:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/12310162/2001
7 years, 9 months ago (2013-02-28 15:24:17 UTC) #8
commit-bot: I haz the power
7 years, 9 months ago (2013-02-28 16:32:34 UTC) #9
Message was sent while issue was closed.
Change committed as 185260

Powered by Google App Engine
This is Rietveld 408576698