Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 12310156: Use updated Khronos signature for glShaderSource (Closed)

Created:
7 years, 10 months ago by Paweł Hajdan Jr.
Modified:
7 years, 9 months ago
Reviewers:
Stephen White
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Use updated Khronos signature for glShaderSource (const char* const instead of char**). This is needed for new Khronos headers. BUG=178589 Committed: http://code.google.com/p/skia/source/detail?r=7900

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M gpu/gl/GrGLConfig_chrome.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Paweł Hajdan Jr.
If you want to add more people to review, please do so directly (do not ...
7 years, 10 months ago (2013-02-27 00:36:38 UTC) #1
bsalomon
On 2013/02/27 00:36:38, Paweł Hajdan Jr. wrote: > If you want to add more people ...
7 years, 9 months ago (2013-02-27 19:20:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/phajdan.jr@chromium.org/12310156/1
7 years, 9 months ago (2013-02-27 19:20:53 UTC) #3
commit-bot: I haz the power
Presubmit check for 12310156-1 failed and returned exit status 1. INFO:root:Found 1 file(s). Running presubmit ...
7 years, 9 months ago (2013-02-27 19:20:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/phajdan.jr@chromium.org/12310156/1
7 years, 9 months ago (2013-02-28 17:11:07 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-02-28 17:11:12 UTC) #6
Message was sent while issue was closed.
Change committed as 7900

Powered by Google App Engine
This is Rietveld 408576698