Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 12310145: ChromeFrame sites in IE would appear truncated at times. (Closed)

Created:
7 years, 10 months ago by ananta
Modified:
7 years, 10 months ago
Reviewers:
robertshield
CC:
chromium-reviews, grt+watch_chromium.org, amit, robertshield
Visibility:
Public.

Description

ChromeFrame sites in IE would appear truncated at times. This was a regression caused by the change to invalidate the cached protocol data when IE (urlmon) terminates the protocol. While this works well for non CF requests, for CF requests when we report the changed mime type to be that of chrome, the protocol is terminated with cached data. When Chrome attempts to read it we don't have anything to report which leads to the problem. Fix is to not invalidate the protocol data for Chrome requests in our Terminate hook. We should invalidate it for Abort because that seems like an error condition. BUG=178421 R=robertshield. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184718

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome_frame/protocol_sink_wrap.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ananta
7 years, 10 months ago (2013-02-26 20:04:03 UTC) #1
robertshield
LGTM. Could you add a TODO to write a test for this? I think it ...
7 years, 10 months ago (2013-02-26 20:06:08 UTC) #2
ananta
7 years, 10 months ago (2013-02-26 20:09:31 UTC) #3
On 2013/02/26 20:06:08, robertshield wrote:
> LGTM. Could you add a TODO to write a test for this? I think it should be
> relatively easy to write (I don't mind doing it if you're swamped).

done.

Powered by Google App Engine
This is Rietveld 408576698