Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12310059: Move app_host target from c/b/extensions into src/apps. (Closed)

Created:
7 years, 10 months ago by benwells
Modified:
7 years, 10 months ago
CC:
chromium-reviews, tfarina, Aaron Boodman, chromium-apps-reviews_chromium.org, erikwright (departed), chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Move app_host code from extensions into src/apps. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184295

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -618 lines) Patch
A + apps/app_host/DEPS View 1 chunk +3 lines, -3 lines 0 comments Download
A + apps/app_host/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + apps/app_host/app_host.rc View 1 chunk +1 line, -1 line 0 comments Download
A + apps/app_host/app_host_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + apps/app_host/app_host_resource.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + apps/app_host/binaries_installer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + apps/app_host/binaries_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
A + apps/app_host/update.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + apps/app_host/update.cc View 1 chunk +1 line, -1 line 0 comments Download
M apps/apps.gypi View 1 chunk +39 lines, -0 lines 0 comments Download
D chrome/browser/extensions/app_host/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/extensions/app_host/app_host.rc View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/extensions/app_host/app_host_main.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/extensions/app_host/app_host_resource.h View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/browser/extensions/app_host/binaries_installer.h View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/browser/extensions/app_host/binaries_installer.cc View 1 chunk +0 lines, -327 lines 0 comments Download
D chrome/browser/extensions/app_host/update.h View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/browser/extensions/app_host/update.cc View 1 chunk +0 lines, -102 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
benwells
7 years, 10 months ago (2013-02-22 07:49:44 UTC) #1
Ben Goodger (Google)
lgtm
7 years, 10 months ago (2013-02-22 21:50:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/12310059/1
7 years, 10 months ago (2013-02-23 01:46:19 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-02-23 06:17:02 UTC) #4
Message was sent while issue was closed. 
Change committed as 184295

Powered by Google App Engine
This is Rietveld 408576698