Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3871)

Unified Diff: chrome/browser/ui/webui/sync_setup_handler.cc

Issue 12310009: Merge 182705 (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1410/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/options/browser_options_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/sync_setup_handler.cc
===================================================================
--- chrome/browser/ui/webui/sync_setup_handler.cc (revision 183433)
+++ chrome/browser/ui/webui/sync_setup_handler.cc (working copy)
@@ -1137,14 +1137,19 @@
// 3) Previously working credentials have expired.
// 4) User is already signed in, but App Notifications needs to force another
// login so it can fetch an oauth token (passes force_login=true)
- // 5) User clicks [Advanced Settings] button on options page while already
+ // 5) User is signed in, but has stopped sync via the google dashboard, and
+ // signout is prohibited by policy so we need to force a re-auth.
+ // 6) User clicks [Advanced Settings] button on options page while already
// logged in.
- // 6) One-click signin (credentials are already available, so should display
+ // 7) One-click signin (credentials are already available, so should display
// sync configure UI, not login UI).
- // 7) ChromeOS re-enable after disabling sync.
+ // 8) ChromeOS re-enable after disabling sync.
SigninManager* signin = GetSignin();
if (force_login ||
signin->GetAuthenticatedUsername().empty() ||
+#if !defined(OS_CHROMEOS)
+ (GetSyncService() && GetSyncService()->IsStartSuppressed()) ||
+#endif
signin->signin_global_error()->HasBadge()) {
// User is not logged in, or login has been specially requested - need to
// display login UI (cases 1-4).
« no previous file with comments | « chrome/browser/ui/webui/options/browser_options_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698