Issue 12310002: Move ant call from python to gyp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12310002: Move ant call from python to gyp (Closed)

Created:
7 years, 10 months ago by cjhopman

Modified:
7 years, 10 months ago

Reviewers:
Yaron

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Move ant call from python to gyp All of our APKs should be built with build/java_apk.gypi. Currently, native test APKs are built very differently. This change makes them build more like other apks, as a first step to using java_apk.gypi. Since WebKit's gyp files use generate_native_test.py directly, rather than including apk_test.gypi, generate_native_test.py needs to continue to support using it for ant compilation. :( BUG=177121 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183614

Patch Set 1 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -23 lines)			Patch
	M	build/apk_test.gypi	View		2 chunks	+24 lines, -12 lines	0 comments	Download
	M	testing/android/generate_native_test.py	View		2 chunks	+12 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/12310002/2001

7 years, 10 months ago (2013-02-20 17:38:50 UTC) #3

Message was sent while issue was closed.

Change committed as 183614

Expand Messages | Collapse Messages