Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 12304038: Restore 'Chrome Style' buttons for --enable-new-dialog-style dialogs. (Closed)

Created:
7 years, 10 months ago by msw
Modified:
7 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Restore 'Chrome Style' buttons for --enable-new-dialog-style dialogs. My recent http://crrev.com/183286 mistakenly removed this styling. (this only affects dialogs with the experimental --enable-new-dialog-style) BUG=166075 TEST=New dialog style buttons look okay. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183438

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M ui/views/window/dialog_client_view.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
msw
Hey Scott, sorry I missed this, please take a look; thanks!
7 years, 10 months ago (2013-02-20 00:10:45 UTC) #1
sky
LGTM
7 years, 10 months ago (2013-02-20 00:42:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/12304038/1
7 years, 10 months ago (2013-02-20 01:10:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/12304038/1
7 years, 10 months ago (2013-02-20 07:50:12 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-20 09:21:54 UTC) #5
Message was sent while issue was closed.
Change committed as 183438

Powered by Google App Engine
This is Rietveld 408576698