Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12304015: Migrated sync_file_status, sync_action and sync_direction from fileapi:: namespace to sync_file_sys… (Closed)

Created:
7 years, 10 months ago by calvinlo
Modified:
7 years, 10 months ago
Reviewers:
kinuko, tzik
CC:
chromium-reviews, tzik+watch_chromium.org, Aaron Boodman, kinuko+watch, darin-cc_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Migrated sync_file_status, sync_action and sync_direction from fileapi:: namespace to sync_file_system:: namespace. BUG=174870 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184059

Patch Set 1 #

Patch Set 2 : Revised TODOs #

Total comments: 2

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -152 lines) Patch
M chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc View 4 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/extensions/api/sync_file_system/sync_file_system_api.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_service.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_service.cc View 1 2 18 chunks +47 lines, -47 lines 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_service_unittest.cc View 1 2 6 chunks +19 lines, -19 lines 0 comments Download
M chrome/browser/sync_file_system/file_status_observer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/mock_remote_file_sync_service.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/mock_remote_file_sync_service.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/sync_event_observer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service_unittest.cc View 7 chunks +18 lines, -18 lines 0 comments Download
M webkit/fileapi/syncable/sync_action.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M webkit/fileapi/syncable/sync_callbacks.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M webkit/fileapi/syncable/sync_direction.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M webkit/fileapi/syncable/sync_file_status.h View 1 chunk +1 line, -2 lines 0 comments Download
M webkit/fileapi/syncable/sync_status_code.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
calvinlo
Here's part 1. I'll update sync_callback and sync_status_code next but this patch list is already ...
7 years, 10 months ago (2013-02-19 08:38:39 UTC) #1
tzik
LGTM with nits https://codereview.chromium.org/12304015/diff/2001/chrome/browser/sync_file_system/drive_file_sync_service.cc File chrome/browser/sync_file_system/drive_file_sync_service.cc (left): https://codereview.chromium.org/12304015/diff/2001/chrome/browser/sync_file_system/drive_file_sync_service.cc#oldcode155 chrome/browser/sync_file_system/drive_file_sync_service.cc:155: void DriveFileSyncService::SetPushNotificationEnabled( Could you rebase for ...
7 years, 10 months ago (2013-02-19 09:09:00 UTC) #2
calvinlo
Rebase done, PTAL again. https://codereview.chromium.org/12304015/diff/2001/chrome/browser/sync_file_system/drive_file_sync_service.cc File chrome/browser/sync_file_system/drive_file_sync_service.cc (left): https://codereview.chromium.org/12304015/diff/2001/chrome/browser/sync_file_system/drive_file_sync_service.cc#oldcode155 chrome/browser/sync_file_system/drive_file_sync_service.cc:155: void DriveFileSyncService::SetPushNotificationEnabled( On 2013/02/19 09:09:01, ...
7 years, 10 months ago (2013-02-20 04:04:30 UTC) #3
tzik
On 2013/02/20 04:04:30, calvinlo wrote: > Rebase done, PTAL again. > > https://codereview.chromium.org/12304015/diff/2001/chrome/browser/sync_file_system/drive_file_sync_service.cc > File ...
7 years, 10 months ago (2013-02-21 04:54:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calvinlo@chromium.org/12304015/10001
7 years, 10 months ago (2013-02-21 04:59:36 UTC) #5
commit-bot: I haz the power
Presubmit check for 12304015-10001 failed and returned exit status 1. INFO:root:Found 20 file(s). Running presubmit ...
7 years, 10 months ago (2013-02-21 04:59:46 UTC) #6
kinuko
> Missing LGTM from an OWNER for files in these directories: > chrome/browser/extensions/api/sync_file_system lgtm
7 years, 10 months ago (2013-02-21 05:09:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calvinlo@chromium.org/12304015/10001
7 years, 10 months ago (2013-02-21 06:21:05 UTC) #8
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) build http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=21400
7 years, 10 months ago (2013-02-21 08:03:47 UTC) #9
calvinlo
7 years, 10 months ago (2013-02-22 06:47:35 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 manually as r184059 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698