Issue 12303010: fixes to libcmt stripper to correctly strip x64 objects

Issue 12303010: fixes to libcmt stripper to correctly strip x64 objects (Closed)

Created:
7 years, 10 months ago by Will Harris

Modified:
7 years, 10 months ago

Reviewers:
jschuh, rvargas (doing something else), jar (doing other things), scottmg

CC:
chromium-reviews, erikwright+watch_chromium.org, dmikurube+memory_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

fixes to pre_libc.py script to correctly strip x64 object files from libcmt during 64bit build BUG=166496 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183908

Patch Set 2 : minor logic changes as per code review #

Patch Set 3 : changes to prep_libc to supply target_arch on command line instead of via output directory #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -9 lines)			Patch
	M	base/allocator/allocator.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
	M	base/allocator/prep_libc.py	View	1 2	2 chunks	+17 lines, -9 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

Will Harris

correctly strip the amd64 symbols from libcmt for malloc shim

7 years, 10 months ago (2013-02-18 21:26:46 UTC) #1

jar (doing other things)

I'll rubber stamp based on Ricardo's comments.

7 years, 10 months ago (2013-02-19 06:44:22 UTC) #4

scottmg

lgtm https://codereview.chromium.org/12303010/diff/1/base/allocator/prep_libc.py File base/allocator/prep_libc.py (right): https://codereview.chromium.org/12303010/diff/1/base/allocator/prep_libc.py#newcode45 base/allocator/prep_libc.py:45: 'f:\\dd\\vctools\\crt_bld\\SELF_X86\\' + \ nit; maybe a loop/comprehension and ...

7 years, 10 months ago (2013-02-19 18:11:01 UTC) #5

Will Harris

minor changes to make the object specifications a bit more elegant

7 years, 10 months ago (2013-02-20 05:06:02 UTC) #6

Will Harris

Changed to supply target_arch on the command line, meaning that https://codereview.chromium.org/12300024/ is no longer needed, ...

7 years, 10 months ago (2013-02-21 00:30:18 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/12303010/12001

7 years, 10 months ago (2013-02-21 18:55:03 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/12303010/12001

7 years, 10 months ago (2013-02-21 22:10:43 UTC) #10

Message was sent while issue was closed.

Change committed as 183908

Expand Messages | Collapse Messages