Issue 12302042: Add more IPC unit tests:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12302042: Add more IPC unit tests: (Closed)

Created:
7 years, 10 months ago by alexeypa (please no reviews)

Modified:
7 years, 10 months ago

Reviewers:
garykac

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add more IPC unit tests: - Reattach: re-attaches to a new instance of desktop session agent. - InvalidateRegion: verifies ScreenCapturer::InvalidateRegion(). - InjectClipboard/Key/MouseEvent: test the EventExecutor interface. BUG=134694 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183492

Patch Set 1 #

Patch Set 2 : Fix DesktopProcess shutdown. Test IpcDesktopEnvironmentFactory too." #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+405 lines, -122 lines)			Patch
M	remoting/host/desktop_process.cc	View	1	1 chunk	+5 lines, -4 lines	0 comments	Download
M	remoting/host/desktop_session_connector.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/ipc_desktop_environment.h	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	remoting/host/ipc_desktop_environment.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	remoting/host/ipc_desktop_environment_unittest.cc	View	1	12 chunks	+394 lines, -112 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

alexeypa (please no reviews)

Re-landing changes to the IPC test. Patch #1 is the original change. Changes in the ...

7 years, 10 months ago (2013-02-20 00:44:01 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/12302042/1001

7 years, 10 months ago (2013-02-20 01:15:38 UTC) #3

Message was sent while issue was closed.

Change committed as 183492

Expand Messages | Collapse Messages