Make safesync w/ git hash work when lkgr is ahead of clone.

Make safesync w/ git hash work when lkgr is ahead of clone.


R=maruel@chromium.org, szager@chromium.org
BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=183275

[iannucci, 2013-02-18 04:17:54]

PTAL

[iannucci, 2013-02-18 04:22:10]

On 2013/02/18 04:17:54, iannucci wrote:
> PTAL

Note: Someone (possibly me) should later fix gclient so that it works with a
safesync url on the initial sync, too. If I'm understanding the code correctly,
svn safesync currently fails with a cryptic error, and a git hash safesync url
dumps a traceback. The new code gives a more meaningful error in both cases, but
it would be great to actually make this flow work... Even just a semi-hack to
take safesync at its word if the repo doesn't exist would work, I think.

[szager1, 2013-02-19 19:06:08]

lgtm

[M-A Ruel, 2013-02-19 19:07:44]

https://codereview.chromium.org/12301002/diff/2001/gclient_scm.py
File gclient_scm.py (right):

https://codereview.chromium.org/12301002/diff/2001/gclient_scm.py#newcode570
gclient_scm.py:570: if not os.path.isdir(self.checkout_path):
Why are you breaking svn users? It's not necessary.

[iannucci, 2013-02-19 19:18:33]

https://codereview.chromium.org/12301002/diff/2001/gclient_scm.py
File gclient_scm.py (right):

https://codereview.chromium.org/12301002/diff/2001/gclient_scm.py#newcode570
gclient_scm.py:570: if not os.path.isdir(self.checkout_path):
On 2013/02/19 19:07:44, Marc-Antoine Ruel wrote:
> Why are you breaking svn users? It's not necessary.

I'm not, this was in the second if statement in the svn code before. I just
moved it earlier, since it's actually common to both. (see my comment in a
previous email on this CL)

[M-A Ruel, 2013-02-19 19:21:42]

lgtm without a unit test. (Just noting absence of a test)

https://codereview.chromium.org/12301002/diff/2001/gclient_scm.py
File gclient_scm.py (right):

https://codereview.chromium.org/12301002/diff/2001/gclient_scm.py#newcode570
gclient_scm.py:570: if not os.path.isdir(self.checkout_path):
On 2013/02/19 19:18:33, iannucci wrote:
> On 2013/02/19 19:07:44, Marc-Antoine Ruel wrote:
> > Why are you breaking svn users? It's not necessary.
> 
> I'm not, this was in the second if statement in the svn code before. I just
> moved it earlier, since it's actually common to both. (see my comment in a
> previous email on this CL)

Oh right, this is only for git checkouts, ok fine.

[commit-bot: I haz the power, 2013-02-19 20:12:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/iannucci@chromium.org/12301002/2001

[commit-bot: I haz the power, 2013-02-19 20:15:19]

Change committed as 183275

[anagy4698, 2013-02-19 20:19:05]

Ejha, az összes fontos üzenetet elolvasta a beérkezett levelek közül!


2013/2/19 <commit-bot@chromium.org>

> Change committed as 183275
>
>
https://chromiumcodereview.**appspot.com/12301002/<https://chromiumcodereview...
>



-- 
anagy4698@gmail.com.