Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Unified Diff: src/ia32/deoptimizer-ia32.cc

Issue 12300020: Remove bogus check for TOP register in deoptimizer. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ia32/deoptimizer-ia32.cc
diff --git a/src/ia32/deoptimizer-ia32.cc b/src/ia32/deoptimizer-ia32.cc
index 9743b65f0b30fc85b71a40ae96574952d41779e0..94b429ba47b00aa5ef0d70075571eabf0635b6aa 100644
--- a/src/ia32/deoptimizer-ia32.cc
+++ b/src/ia32/deoptimizer-ia32.cc
@@ -1214,15 +1214,10 @@ void Deoptimizer::EntryGenerator::Generate() {
}
}
- // Check that the TOP register is zero and clear all exceptions.
- const int kTopMask = 0x3800;
- __ push(eax);
- __ fwait();
- __ fnstsw_ax();
- __ test(eax, Immediate(kTopMask));
- __ Check(zero, "FPU TOP is not zero in deoptimizer.");
+ // Clear FPU all exceptions.
+ // TODO(ulan): Find out why the TOP register is not zero here in some cases,
+ // and check that the generated code never deoptimizes with unbalanced stack.
__ fnclex();
- __ pop(eax);
// Remove the bailout id and the double registers from the stack.
if (type() == EAGER) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698