Chromium Code Reviews Chromium Code Reviews
Issue
12300008:
Save/restore views omnibox selection on blur/focus, select all on click focus. (Closed)
DescriptionSave/restore views omnibox selection on blur/focus, select all on click focus.
*This CL depends on WIP: https://codereview.chromium.org/12299003/
Save saved_temporary_selection_ on OmniboxViewViews::OnBlur().
Restore saved_temporary_selection_ on OmniboxViewViews::OnFocus().
(only if select_all_on_mouse_release_ won't trigger)
Remove code to set the cursor to the text end on [tab] with a normal selection.
Run applicable handlers in NativeTextfieldViews::OnMousePressed.
(textfield_->OnMousePressed wasn't being run properly due to logic error)
BUG=134701, 176708
TEST=Cros (and Win Aura / with --enable-views-textfield) Omnibox behaves more like Windows (select all on click-to-focus, save/restore selection on tab-to-focus)
R=pkasting@chromium.org
TBR=sky@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183239
Patch Set 1 : Save selection on blur, restore on focus (via tab or mouse). #Patch Set 2 : Select all on click-to-focus, instead of restoring the selection. #Patch Set 3 : Sync and rebase #
Total comments: 4
Patch Set 4 : Restore comment. #Patch Set 5 : Sync and rebase. #
Messages
Total messages: 11 (0 generated)
|
||||||||||||||||||||||||||||
