git_cl.py - Issue 12300006: tyop: 'patchsets' seems to be the correct key, not 'patchset'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cl.py

Issue 12300006: tyop: 'patchsets' seems to be the correct key, not 'patchset'. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: git_cl.py

diff --git a/git_cl.py b/git_cl.py

index 11266914aaf022ae3e9884b90451181e9c8e1042..e0bf935cd99cb2e74317f8dda2e89713e0b358af 100755

--- a/git_cl.py

+++ b/git_cl.py

@@ -1496,7 +1496,7 @@ def SendUpstream(parser, args, cmd):

'(you may be prompted for your codereview password)...')

cl.CloseIssue()

props = cl.RpcServer().get_issue_properties(cl.GetIssue(), False)

- patch_num = len(props['patchset'])

+ patch_num = len(props['patchsets'])

comment = "Committed patchset #%d manually as r%s" % (patch_num, revision)

comment += ' (presubmit successful).' if not options.bypass_hooks else '.'

cl.RpcServer().add_comment(cl.GetIssue(), comment)

« no previous file with comments | « no previous file | no next file » | no next file with comments »