Build scripts refactor to support multislave

Build scripts refactor to support multislave

- Consolidate slaves.cfg parsing logic and move
  functions to scripts/common/chromium_utils.
- Misc cleanup

BUG=176628
TBR=cmp

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=185852

[Mike Stip (use stip instead), 2013-02-20 18:42:07]

lgtm

https://chromiumcodereview.appspot.com/12300004/diff/7001/scripts/common/chro...
File scripts/common/chromium_utils.py (right):

https://chromiumcodereview.appspot.com/12300004/diff/7001/scripts/common/chro...
scripts/common/chromium_utils.py:31: os.path.dirname(__file__), os.pardir,
os.pardir))
didn't know os.pardir was a thing. neat!

[Mike Stip (use stip instead), 2013-02-28 18:54:13]

Note: https://codereview.chromium.org/12351003/ implements part of this CL in a
smaller context, the current CL will need to be modified to make sure it doesn't
conflict.

[Isaac (away), 2013-03-04 04:55:23]

I'm going to commit this as-is and make changes on a followup patch.

[commit-bot: I haz the power, 2013-03-04 04:56:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ilevy@chromium.org/12300004/12001

[commit-bot: I haz the power, 2013-03-04 05:00:35]

Presubmit check for 12300004-12001 failed and returned exit status 1.

INFO:root:Found 8 file(s).
INFO:PRESUBMIT:Running pylint on 302 files
48 masters succeeded, 0 failed, 12 skipped in 189.3s.
Trying master.chromium
Trying master.chromium.chrome
Trying master.chromium.chromebot
Trying master.chromium.chromiumos
Trying master.chromium.endure
Trying master.chromium.flaky
Trying master.chromium.fyi
Trying master.chromium.git
Trying master.chromium.gpu
Trying master.chromium.gpu.fyi
Trying master.chromium.linux
Trying master.chromium.lkgr
Trying master.chromium.mac
Trying master.chromium.memory
Trying master.chromium.memory.fyi
Trying master.chromium.perf
Trying master.chromium.perf_av
Trying master.chromium.pyauto
Trying master.chromium.swarm
Trying master.chromium.webkit
Trying master.chromium.webrtc
Trying master.chromium.webrtc.fyi
Trying master.chromium.win
Trying master.chromiumos
Trying master.client.dart
Trying master.client.dart.fyi
Trying master.client.drmemory
Trying master.client.dynamorio
Trying master.client.libjingle
Trying master.client.libyuv
Trying master.client.nacl
Trying master.client.nacl.chrome
Trying master.client.nacl.llvm
Trying master.client.nacl.ports
Trying master.client.nacl.ragel
Trying master.client.nacl.sdk
Trying master.client.nacl.sdk.addin
Trying master.client.nacl.sdk.mono
Trying master.client.nacl.toolchain
Trying master.client.omaha
Trying master.client.pagespeed
Trying master.client.v8
Trying master.client.webrtc
Trying master.devtools
Trying master.tryserver.chromium
Trying master.tryserver.chromium.linux
Trying master.tryserver.nacl
Trying master.tryserver.webrtc
/b/commit-queue/workdir/tools/build/third_party/zope/__init__.py:19:
UserWarning: Module mock was already imported from
/b/commit-queue/workdir/tools/build/third_party/mock-1.0.1/mock.py, but
/usr/local/lib/python2.6/dist-packages/mock-1.0b1-py2.6.egg is being added to
sys.path
  import pkg_resources
test_android (__main__.TestMailNotifier) ... ok
test_cq_succeed (__main__.TestMailNotifier) ... ok
test_simple (__main__.TestMailNotifier) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.254s

OK
Parsing client.v8
Parsing chromium.endure
Parsing chromium.memory
Skipping chromium.swarm, fix and enable in masters_cfg_test.py!
Skipping client.nacl.chrome, fix and enable in masters_cfg_test.py!
Parsing experimental
Parsing chromium.win
Parsing client.skia
Parsing chromium
Parsing tryserver.webrtc
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
Parsing client.sfntly
Parsing chromium.webrtc
Parsing client.dart.fyi
Parsing chromium.webrtc.fyi
Parsing client.pagespeed
Parsing chromium.pyauto
Parsing client.libjingle
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
Parsing tryserver.chromium
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-dir option on linux. This is almost
certainly incorrect.
Assuming you meant "src/sconsbuild"
WARNING: Passed "src/build" as --build-d…
(message too large)

[Isaac (away), 2013-03-04 08:47:20]

This stupid CQ message was trying to tell me I didn't have an LGTM for the
slave/ directory, which has 'set noparent' enabled.  I am TBRing to cmp as the
code in this refactor is pretty innocuous.

[commit-bot: I haz the power, 2013-03-04 08:48:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ilevy@chromium.org/12300004/12001

[commit-bot: I haz the power, 2013-03-04 08:52:57]

Change committed as 185852