Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 12300002: Make gclient_scm_test pass even if no global user name or email is defined. (Closed)

Created:
7 years, 10 months ago by iannucci
Modified:
7 years, 10 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Make gclient_scm_test pass even if no global user name or email is defined. R=maruel@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=183044

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tests/gclient_scm_test.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
iannucci
7 years, 10 months ago (2013-02-17 01:09:37 UTC) #1
M-A Ruel
lgtm
7 years, 10 months ago (2013-02-17 14:04:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/12300002/1
7 years, 10 months ago (2013-02-17 20:51:31 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-02-17 20:54:07 UTC) #4
Message was sent while issue was closed.
Change committed as 183044

Powered by Google App Engine
This is Rietveld 408576698