Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 12299015: Make clearkey build on Win64 (Closed)

Created:
7 years, 10 months ago by jschuh
Modified:
7 years, 10 months ago
Reviewers:
ddorwin
CC:
chromium-reviews, feature-media-reviews_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Make clearkey build on Win64 Just c4267 build suppressions. BUG=166496 BUG=167187 TBR=ddorwin@chromium.org R=ddorwin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183136

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M webkit/media/webkit_media.gypi View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/12299015/1
7 years, 10 months ago (2013-02-18 16:00:16 UTC) #1
commit-bot: I haz the power
Change committed as 183136
7 years, 10 months ago (2013-02-18 18:56:10 UTC) #2
ddorwin
Are there issues in our code that should be fixed? LGTM
7 years, 10 months ago (2013-02-18 21:26:26 UTC) #3
jschuh
7 years, 10 months ago (2013-02-18 22:24:35 UTC) #4
Message was sent while issue was closed.
On 2013/02/18 21:26:26, ddorwin wrote:
> Are there issues in our code that should be fixed?

Nothing unique to this. We have a huge problem with potentially unsafe
conversions everywhere. The first step is to add narrow suppressions so we can
get a bot up to catch new ones. Then we'll circle back and clean things up.

Powered by Google App Engine
This is Rietveld 408576698