Fix top-level context menus sorting by name

chrome/browser/tab_contents/render_view_context_menu.cc

Index: chrome/browser/tab_contents/render_view_context_menu.cc
diff --git a/chrome/browser/tab_contents/render_view_context_menu.cc b/chrome/browser/tab_contents/render_view_context_menu.cc
index ad04d13ccb11812499cbba15b51456de989ab4a9..0885a3b8c8ed1f95d785699698112c2902a196d0 100644
--- a/chrome/browser/tab_contents/render_view_context_menu.cc
+++ b/chrome/browser/tab_contents/render_view_context_menu.cc
@@ -506,17 +506,23 @@ void RenderViewContextMenu::AppendAllExtensionItems() {
     return;  // In unit-tests, we may not have an ExtensionService.
   MenuManager* menu_manager = service->menu_manager();
 
-  // Get a list of extension id's that have context menu items, and sort it by
-  // the extension's name.
+  string16 printable_selection_text = PrintableSelectionText();
+  EscapeAmpersands(&printable_selection_text);
+
+  // Get a list of extension id's that have context menu items, and sort by the
+  // top level context menu title of the extension.
   std::set<std::string> ids = menu_manager->ExtensionIds();
   std::vector<std::pair<std::string, std::string> > sorted_ids;
   for (std::set<std::string>::iterator i = ids.begin(); i != ids.end(); ++i) {
     const Extension* extension = service->GetExtensionById(*i, false);
     // Platform apps have their context menus created directly in
     // AppendPlatformAppItems.
-    if (extension && !extension->is_platform_app())
+    if (extension && !extension->is_platform_app()) {
+      std::string menu_title = extension_items_.GetTopLevelContextMenuTitle(
+          *i, printable_selection_text);
       sorted_ids.push_back(
-          std::pair<std::string, std::string>(extension->name(), *i));
+          std::pair<std::string, std::string>(menu_title, *i));
+    }
   }
   // TODO(asargent) - See if this works properly for i18n names (bug 32363).

[Avi (use Gerrit), 2013/06/06 14:42:27]

No, std::sort will do completely the wrong thing.

   std::sort(sorted_ids.begin(), sorted_ids.end());
@@ -527,14 +533,9 @@ void RenderViewContextMenu::AppendAllExtensionItems() {
   int index = 0;
   base::TimeTicks begin = base::TimeTicks::Now();
   std::vector<std::pair<std::string, std::string> >::const_iterator i;
-  for (i = sorted_ids.begin();
-       i != sorted_ids.end(); ++i) {
-    string16 printable_selection_text = PrintableSelectionText();
-    EscapeAmpersands(&printable_selection_text);
-
+  for (i = sorted_ids.begin(); i != sorted_ids.end(); ++i)
     extension_items_.AppendExtensionItems(i->second, printable_selection_text,
                                           &index);
-  }
   UMA_HISTOGRAM_TIMES("Extensions.ContextMenus_BuildTime",
                       base::TimeTicks::Now() - begin);
   UMA_HISTOGRAM_COUNTS("Extensions.ContextMenus_ItemCount", index);