Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2679)

Unified Diff: chrome/browser/extensions/context_menu_matcher.h

Issue 12299013: Fix top-level context menus sorting by name (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/
Patch Set: I have no excuse here... Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/context_menu_matcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/context_menu_matcher.h
diff --git a/chrome/browser/extensions/context_menu_matcher.h b/chrome/browser/extensions/context_menu_matcher.h
index 3dee9bdb268470560e7ccba20963314486de51be..d37516338eec28d80f331743f1aa4d24a145dad7 100644
--- a/chrome/browser/extensions/context_menu_matcher.h
+++ b/chrome/browser/extensions/context_menu_matcher.h
@@ -40,6 +40,11 @@ class ContextMenuMatcher {
void Clear();
+ // This function returns the top level context menu title of an extension
+ // based on a printable selection text.
+ base::string16 GetTopLevelContextMenuTitle(const std::string& extension_id,
+ const string16& selection_text);
+
bool IsCommandIdChecked(int command_id) const;
bool IsCommandIdEnabled(int command_id) const;
void ExecuteCommand(int command_id,
@@ -49,6 +54,12 @@ class ContextMenuMatcher {
private:
friend class ::ExtensionContextMenuBrowserTest;
+ bool GetRelevantExtensionTopLevelItems(
+ const std::string& extension_id,
+ const Extension** extension,
+ bool* can_cross_incognito,
+ MenuItem::List& items);
+
MenuItem::List GetRelevantExtensionItems(
const MenuItem::List& items,
bool can_cross_incognito);
« no previous file with comments | « no previous file | chrome/browser/extensions/context_menu_matcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698