Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: chrome/android/java/res/layout/snackbar.xml

Issue 1229733002: Add new snackbar features to prepare for omnibox geolocation snackbar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/snackbar.xml
diff --git a/chrome/android/java/res/layout/snack_bar.xml b/chrome/android/java/res/layout/snackbar.xml
similarity index 75%
rename from chrome/android/java/res/layout/snack_bar.xml
rename to chrome/android/java/res/layout/snackbar.xml
index 297917c38d44e71b657330adfe4ad1871ef8d9b6..41669de0be73fa0a741ff4f92c92dd110dae6117 100644
--- a/chrome/android/java/res/layout/snack_bar.xml
+++ b/chrome/android/java/res/layout/snackbar.xml
@@ -4,35 +4,35 @@
found in the LICENSE file. -->
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
- android:id="@+id/undobar"
android:layout_width="match_parent"
- android:layout_height="@dimen/undo_bar_height"
+ android:layout_height="wrap_content"
android:background="#282C32"
- android:orientation="horizontal" >
+ android:minHeight="@dimen/snackbar_min_height"
newt (away) 2015/07/08 22:12:56 single-line snackbar height is still 48dp
+ android:orientation="horizontal"
+ android:paddingTop="14dp"
+ android:paddingBottom="14dp" >
<org.chromium.chrome.browser.snackbar.TemplatePreservingTextView
- android:id="@+id/undobar_message"
+ android:id="@+id/snackbar_message"
android:layout_width="0dp"
android:layout_height="wrap_content"
android:layout_gravity="start|center_vertical"
android:layout_marginStart="24dp"
android:layout_weight="1"
- android:singleLine="true"
newt (away) 2015/07/08 22:12:56 This is now set programmatically (and only in some
android:textAlignment="viewStart"
android:textColor="@android:color/white"
android:textSize="14sp" />
<TextView
- android:id="@+id/undobar_button"
+ android:id="@+id/snackbar_button"
android:layout_width="wrap_content"
android:layout_height="match_parent"
android:fontFamily="sans-serif-medium"
android:gravity="center_vertical"
android:paddingEnd="24dp"
android:paddingStart="24dp"
- android:text="@string/undo_bar_button_text"
android:textAllCaps="true"
- android:textColor="@color/snack_bar_button_color"
+ android:textColor="@color/snackbar_button_color"
android:textSize="14sp" />
</LinearLayout>

Powered by Google App Engine
This is Rietveld 408576698