Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12297011: SystemInfo API Doc (Closed)

Created:
7 years, 10 months ago by Hongbo Min
Modified:
7 years, 6 months ago
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add display API Documentations to Doc server Remove systemInfo.cpu and systemInfo.storage from extensions template and add systemInfo.display template. TBR=kalman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202430

Patch Set 1 #

Patch Set 2 : fix old mismatch chunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
A chrome/common/extensions/docs/templates/public/apps/systemInfo_display.html View 1 chunk +1 line, -0 lines 0 comments Download
D chrome/common/extensions/docs/templates/public/extensions/experimental_systemInfo_cpu.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/templates/public/extensions/experimental_systemInfo_storage.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Hongbo Min
kalman, please have a review.
7 years, 10 months ago (2013-02-18 07:44:29 UTC) #1
not at google - send to devlin
I'm just seeing "error: old chunk mismatch". +mkearney
7 years, 10 months ago (2013-02-19 16:41:06 UTC) #2
Hongbo Min
On 2013/02/19 16:41:06, kalman wrote: > I'm just seeing "error: old chunk mismatch". > > ...
7 years, 7 months ago (2013-05-22 06:18:06 UTC) #3
not at google - send to devlin
I am still seeing "old chunk mismatch", perhaps try rebasing and re-uploading.
7 years, 7 months ago (2013-05-22 15:05:11 UTC) #4
Hongbo Min
On 2013/05/22 15:05:11, kalman wrote: > I am still seeing "old chunk mismatch", perhaps try ...
7 years, 7 months ago (2013-05-23 01:46:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hongbo.min@intel.com/12297011/32001
7 years, 7 months ago (2013-05-27 02:50:04 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=118574
7 years, 7 months ago (2013-05-27 04:56:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hongbo.min@intel.com/12297011/32001
7 years, 7 months ago (2013-05-27 14:44:58 UTC) #8
commit-bot: I haz the power
Change committed as 202430
7 years, 7 months ago (2013-05-27 15:19:56 UTC) #9
not at google - send to devlin
Why did you submit this patch? The system info API is available to extensions as ...
7 years, 6 months ago (2013-05-28 14:23:52 UTC) #10
not at google - send to devlin
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/extensions/api/_permission_features.json&q=permission_features.json&sq=package:chromium&l=479
7 years, 6 months ago (2013-05-28 14:24:06 UTC) #11
Hongbo Min
7 years, 6 months ago (2013-05-30 03:17:37 UTC) #12
Message was sent while issue was closed. 
On 2013/05/28 14:23:52, kalman wrote:
> Why did you submit this patch?
> 
> The system info API is available to extensions as well as apps.

You are right. Thanks.

Powered by Google App Engine
This is Rietveld 408576698